From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <s.ivanov@proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 8DBAA73DA1 for <pve-devel@lists.proxmox.com>; Wed, 7 Jul 2021 23:10:12 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 6EAFDFC58 for <pve-devel@lists.proxmox.com>; Wed, 7 Jul 2021 23:10:12 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 48BD0FC2A for <pve-devel@lists.proxmox.com>; Wed, 7 Jul 2021 23:10:11 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 1684A40EF7 for <pve-devel@lists.proxmox.com>; Wed, 7 Jul 2021 23:10:11 +0200 (CEST) From: Stoiko Ivanov <s.ivanov@proxmox.com> To: pve-devel@lists.proxmox.com Date: Wed, 7 Jul 2021 23:09:50 +0200 Message-Id: <20210707210954.765260-2-s.ivanov@proxmox.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20210707210954.765260-1-s.ivanov@proxmox.com> References: <20210707210954.765260-1-s.ivanov@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.500 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH pve-kernel-meta 1/5] proxmox-boot: ignore call to grub-install from grub maintscripts X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/> List-Post: <mailto:pve-devel@lists.proxmox.com> List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe> X-List-Received-Date: Wed, 07 Jul 2021 21:10:12 -0000 in certain cases the postinst script of grub-pc runs grub-install on the disks it gets from debconf. Simply warn and exit with 0 if grub-install is called by dpkg and from a grub related package Signed-off-by: Stoiko Ivanov <s.ivanov@proxmox.com> --- bin/grub-install-wrapper | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/bin/grub-install-wrapper b/bin/grub-install-wrapper index a61e984..35f03fa 100755 --- a/bin/grub-install-wrapper +++ b/bin/grub-install-wrapper @@ -4,6 +4,12 @@ set -e . /usr/share/pve-kernel-helper/scripts/functions if proxmox-boot-tool status --quiet; then + #detect when being called by dpkg (e.g. grub-pc.postinst + if [ -n "$DPKG_RUNNING_VERSION" ] && \ + echo "$DPKG_MAINTSCRIPT_PACKAGE" | grep -sq "^grub-"; then + warn "This system is booted via proxmox-boot-tool, ignoring dpkg call to grub-install" + exit 0 + fi warn "grub-install is disabled because this system is booted via proxmox-boot-tool, if you really need to run it, run /usr/sbin/grub-install.real" exit 1 else -- 2.30.2