From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 5D93F73B8B for ; Wed, 7 Jul 2021 13:54:39 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 4AC6D2F83F for ; Wed, 7 Jul 2021 13:54:39 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id D80E92F836 for ; Wed, 7 Jul 2021 13:54:38 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id ACC9E40E4D for ; Wed, 7 Jul 2021 13:54:38 +0200 (CEST) From: Dominik Csapak To: pve-devel@lists.proxmox.com Date: Wed, 7 Jul 2021 13:54:37 +0200 Message-Id: <20210707115437.23670-1-d.csapak@proxmox.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.935 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% ENA_SUBJ_ODD_CASE 3.2 Subject has odd case KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH manager] ui: dc/AuthEditOpenId: remove unnecessary code X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 07 Jul 2021 11:54:39 -0000 we do not have a 'verify' field here, so the onGetValues override falsely sent 'delete: verify' on every edit while our api is ok with that, it's better to remove it Signed-off-by: Dominik Csapak --- www/manager6/dc/AuthEditOpenId.js | 13 ------------- 1 file changed, 13 deletions(-) diff --git a/www/manager6/dc/AuthEditOpenId.js b/www/manager6/dc/AuthEditOpenId.js index 7ebb9c8f..2dd60d1b 100644 --- a/www/manager6/dc/AuthEditOpenId.js +++ b/www/manager6/dc/AuthEditOpenId.js @@ -3,19 +3,6 @@ Ext.define('PVE.panel.OpenIDInputPanel', { xtype: 'pveAuthOpenIDPanel', mixins: ['Proxmox.Mixin.CBind'], - onGetValues: function(values) { - let me = this; - - if (!values.verify) { - if (!me.isCreate) { - Proxmox.Utils.assemble_field_data(values, { 'delete': 'verify' }); - } - delete values.verify; - } - - return me.callParent([values]); - }, - columnT: [ { xtype: 'textfield', -- 2.30.2