From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 9926573B39 for ; Wed, 7 Jul 2021 13:29:11 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 863F92F067 for ; Wed, 7 Jul 2021 13:28:41 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id E9FB62F05C for ; Wed, 7 Jul 2021 13:28:39 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id B917140EC7 for ; Wed, 7 Jul 2021 13:28:39 +0200 (CEST) From: Fabian Ebner To: pve-devel@lists.proxmox.com Date: Wed, 7 Jul 2021 13:28:35 +0200 Message-Id: <20210707112835.50710-1-f.ebner@proxmox.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.558 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH qemu-server] cfg2cmd: avoid io_uring with LVM and write{back, through} cache X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 07 Jul 2021 11:29:11 -0000 Reported in the community forum[0]. Also tried with LVM-thin, but it doesn't seem to be affected. See also 628937f53acde52f7257ca79f574c87a45f392e7 for the same fix for krbd. [0]: https://forum.proxmox.com/threads/after-upgrade-to-7-0-all-vms-dont-boot.92019/post-401017 Signed-off-by: Fabian Ebner --- PVE/QemuServer.pm | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm index 8fc90e2..b0fe257 100644 --- a/PVE/QemuServer.pm +++ b/PVE/QemuServer.pm @@ -1605,8 +1605,11 @@ sub print_drive_commandline_full { # io_uring with cache mode writeback or writethrough on krbd will hang... my $rbd_no_io_uring = $scfg && $scfg->{type} eq 'rbd' && $scfg->{krbd} && !$cache_direct; + # io_uring with cache mode writeback or writethrough on LVM will hang... + my $lvm_no_io_uring = $scfg && $scfg->{type} eq 'lvm' && !$cache_direct; + if (!$drive->{aio}) { - if ($io_uring && !$rbd_no_io_uring) { + if ($io_uring && !$rbd_no_io_uring && !$lvm_no_io_uring) { # io_uring supports all cache modes $opts .= ",aio=io_uring"; } else { -- 2.30.2