From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id A00DA73B09 for ; Wed, 7 Jul 2021 12:23:27 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 94E0F2DF34 for ; Wed, 7 Jul 2021 12:22:57 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id D9A7C2DF22 for ; Wed, 7 Jul 2021 12:22:56 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id A75E240EA3 for ; Wed, 7 Jul 2021 12:22:56 +0200 (CEST) From: Fabian Ebner To: pve-devel@lists.proxmox.com Date: Wed, 7 Jul 2021 12:22:49 +0200 Message-Id: <20210707102250.5478-1-f.ebner@proxmox.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.562 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH manager 1/2] pve6to7: storage content: skip scanning storage if shared X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 07 Jul 2021 10:23:27 -0000 Shared storages are not scanned for migration either, so they cannot be problematic in this context. This could lead to false positives where it actually is completely unproblematic: https://forum.proxmox.com/threads/proxmox-ve-7-0-released.92007/post-401165 Signed-off-by: Fabian Ebner --- PVE/CLI/pve6to7.pm | 1 + 1 file changed, 1 insertion(+) diff --git a/PVE/CLI/pve6to7.pm b/PVE/CLI/pve6to7.pm index 69ed6d2e..17da70e8 100644 --- a/PVE/CLI/pve6to7.pm +++ b/PVE/CLI/pve6to7.pm @@ -707,6 +707,7 @@ sub check_storage_content { for my $storeid (sort keys $storage_cfg->{ids}->%*) { my $scfg = $storage_cfg->{ids}->{$storeid}; + next if $scfg->{shared}; next if !PVE::Storage::storage_check_enabled($storage_cfg, $storeid, undef, 1); my $valid_content = PVE::Storage::Plugin::valid_content_types($scfg->{type}); -- 2.20.1