From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <d.csapak@proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
key-exchange X25519 server-signature RSA-PSS (2048 bits))
(No client certificate requested)
by lists.proxmox.com (Postfix) with ESMTPS id 77FDF73237
for <pve-devel@lists.proxmox.com>; Mon, 5 Jul 2021 16:34:34 +0200 (CEST)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
by firstgate.proxmox.com (Proxmox) with ESMTP id 6AF3921440
for <pve-devel@lists.proxmox.com>; Mon, 5 Jul 2021 16:34:04 +0200 (CEST)
Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com
[94.136.29.106])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
key-exchange X25519 server-signature RSA-PSS (2048 bits))
(No client certificate requested)
by firstgate.proxmox.com (Proxmox) with ESMTPS id 565BD2141B
for <pve-devel@lists.proxmox.com>; Mon, 5 Jul 2021 16:34:03 +0200 (CEST)
Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1])
by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 197E640C4D
for <pve-devel@lists.proxmox.com>; Mon, 5 Jul 2021 16:34:03 +0200 (CEST)
From: Dominik Csapak <d.csapak@proxmox.com>
To: pve-devel@lists.proxmox.com
Date: Mon, 5 Jul 2021 16:34:00 +0200
Message-Id: <20210705143402.2362828-2-d.csapak@proxmox.com>
X-Mailer: git-send-email 2.30.2
In-Reply-To: <20210705143402.2362828-1-d.csapak@proxmox.com>
References: <20210705143402.2362828-1-d.csapak@proxmox.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-SPAM-LEVEL: Spam detection results: 0
AWL 0.679 Adjusted score from AWL reputation of From: address
BAYES_00 -1.9 Bayes spam probability is 0 to 1%
KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record
SPF_PASS -0.001 SPF: sender matches SPF record
Subject: [pve-devel] [PATCH widget-toolkit 2/4] node/Tasks: deselect entries
when filter changes
X-BeenThere: pve-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>,
<mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>,
<mailto:pve-devel-request@lists.proxmox.com?subject=subscribe>
X-List-Received-Date: Mon, 05 Jul 2021 14:34:34 -0000
since we use a remotefilter on a bufferedstore, the only event where
we can check if the selected element is still there is the 'refresh'
event. Simply deselect if the seleceted element is not in the store
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
src/node/Tasks.js | 15 +++++++++++++++
1 file changed, 15 insertions(+)
diff --git a/src/node/Tasks.js b/src/node/Tasks.js
index 0c5b79a..d93111b 100644
--- a/src/node/Tasks.js
+++ b/src/node/Tasks.js
@@ -44,6 +44,20 @@ Ext.define('Proxmox.node.Tasks', {
me.getView().updateLayout();
},
+ refresh: function() {
+ let me = this;
+ let view = me.getView();
+
+ let selection = view.getSelection();
+ let store = me.getViewModel().get('bufferedstore');
+ if (selection && selection.length > 0) {
+ // deselect if selection is not there anymore
+ if (!store.contains(selection[0])) {
+ view.setSelection(undefined);
+ }
+ }
+ },
+
sinceChange: function(field, newval) {
let me = this;
let vm = me.getViewModel();
@@ -144,6 +158,7 @@ Ext.define('Proxmox.node.Tasks', {
},
listeners: {
prefetch: 'updateLayout',
+ refresh: 'refresh',
},
},
},
--
2.30.2