From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 9C8E073084 for ; Mon, 5 Jul 2021 12:58:04 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 900461DA27 for ; Mon, 5 Jul 2021 12:57:34 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id A6EC21D9FB for ; Mon, 5 Jul 2021 12:57:33 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 71B9740B12 for ; Mon, 5 Jul 2021 12:57:33 +0200 (CEST) From: Stoiko Ivanov To: pve-devel@lists.proxmox.com Date: Mon, 5 Jul 2021 12:57:17 +0200 Message-Id: <20210705105717.779369-5-s.ivanov@proxmox.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20210705105717.779369-1-s.ivanov@proxmox.com> References: <20210705105717.779369-1-s.ivanov@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.535 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH manager v2 2/2] pve6to7: add 'full' parameter for expensive checks X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 05 Jul 2021 10:58:04 -0000 and place the container cgroupv2 support checks behind it. Signed-off-by: Stoiko Ivanov --- PVE/CLI/pve6to7.pm | 15 ++++++++++++--- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/PVE/CLI/pve6to7.pm b/PVE/CLI/pve6to7.pm index b9aeb89c..5e97a3c5 100644 --- a/PVE/CLI/pve6to7.pm +++ b/PVE/CLI/pve6to7.pm @@ -1119,6 +1119,12 @@ __PACKAGE__->register_method ({ parameters => { additionalProperties => 0, properties => { + full => { + description => 'perform additional, expensive checks.', + type => 'boolean', + optional => 1, + default => 0, + }, }, }, returns => { type => 'null' }, @@ -1131,6 +1137,12 @@ __PACKAGE__->register_method ({ check_storage_health(); check_misc(); + if ($param->{full}) { + check_containers_cgroup_compat(); + } else { + log_skip("Expensive checks not performed without 'full' parameter"); + } + print_header("SUMMARY"); my $total = 0; @@ -1153,7 +1165,4 @@ __PACKAGE__->register_method ({ our $cmddef = [ __PACKAGE__, 'checklist', [], {}]; -# for now drop all unknown params and just check -@ARGV = (); - 1; -- 2.30.2