From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 4F53172F84 for ; Mon, 5 Jul 2021 11:50:07 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 4C9491C89E for ; Mon, 5 Jul 2021 11:50:07 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 953571C895 for ; Mon, 5 Jul 2021 11:50:04 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 602CA40A69 for ; Mon, 5 Jul 2021 11:50:04 +0200 (CEST) From: Fabian Ebner To: pve-devel@lists.proxmox.com Date: Mon, 5 Jul 2021 11:50:00 +0200 Message-Id: <20210705095000.24403-1-f.ebner@proxmox.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.586 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH/RFC manager] pveceph: also install nvme-cli X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 05 Jul 2021 09:50:07 -0000 The nvme-cli package is recommended by (our) Ceph packages, but here --no-install-recommends is used to avoid pulling in too much. The issue with not installing nvme-cli is that a "security information" mail notification is triggered by sudo each time Ceph tries to get the device health metrics. While there is a sudoers rule for /usr/sbin/nvme, Ceph uses 'sudo nvme ...', so it does not apply when the package is not installed. This didn't seem to happen with sudo in buster. It's about 1 MiB of additional packages (nvme-cli + uuid-runtime). Signed-off-by: Fabian Ebner --- An alternative would be to patch Ceph to use the full /usr/sbin/nvme for its call (not tested). PVE/CLI/pveceph.pm | 1 + 1 file changed, 1 insertion(+) diff --git a/PVE/CLI/pveceph.pm b/PVE/CLI/pveceph.pm index f23a996d..356af282 100755 --- a/PVE/CLI/pveceph.pm +++ b/PVE/CLI/pveceph.pm @@ -173,6 +173,7 @@ __PACKAGE__->register_method ({ ceph-mds ceph-fuse gdisk + nvme-cli ); print "start installation\n"; -- 2.30.2