From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 4F4D572A8A for ; Fri, 2 Jul 2021 20:22:09 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 3E8BBC0C3 for ; Fri, 2 Jul 2021 20:22:09 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 818BFC0B0 for ; Fri, 2 Jul 2021 20:22:08 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 462D640551 for ; Fri, 2 Jul 2021 20:22:08 +0200 (CEST) From: Stoiko Ivanov To: pve-devel@lists.proxmox.com Date: Fri, 2 Jul 2021 20:21:52 +0200 Message-Id: <20210702182152.485913-3-s.ivanov@proxmox.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20210702182152.485913-1-s.ivanov@proxmox.com> References: <20210702182152.485913-1-s.ivanov@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.142 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment KAM_NUMSUBJECT 0.5 Subject ends in numbers excluding current years POISEN_SPAM_PILL 0.1 Meta: its spam POISEN_SPAM_PILL_1 0.1 random spam to be learned in bayes POISEN_SPAM_PILL_3 0.1 random spam to be learned in bayes SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [pve6to7.pm] Subject: [pve-devel] [PATCH manager 1/1] pve6to7: check for containers not supporting pure cgroupv2 X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 02 Jul 2021 18:22:09 -0000 Ordered as much as possible to exit early, still might take quite some time on systems with many containers (which do support cgroupv2). needs a versioned bump on pve-container Signed-off-by: Stoiko Ivanov --- PVE/CLI/pve6to7.pm | 68 ++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 68 insertions(+) diff --git a/PVE/CLI/pve6to7.pm b/PVE/CLI/pve6to7.pm index 60edac11..3d7c67bd 100644 --- a/PVE/CLI/pve6to7.pm +++ b/PVE/CLI/pve6to7.pm @@ -23,6 +23,9 @@ use PVE::Tools qw(run_command split_list); use PVE::QemuConfig; use PVE::QemuServer; use PVE::VZDump::Common; +use PVE::LXC; +use PVE::LXC::Config; +use PVE::LXC::Setup; use Term::ANSIColor; @@ -890,6 +893,70 @@ sub check_storage_content { log_pass("no problems found"); } } +sub check_containers_cgroup_compat { + + my $kernel_cli = PVE::Tools::file_get_contents('/proc/cmdline'); + if ($kernel_cli =~ /systemd.unified_cgroup_hierarchy=0/){ + log_skip("System explicitly configured for legacy hybrid cgroup hierarchy."); + return; + } + + my $cts = eval { PVE::API2::LXC->vmlist({ node => $nodename }) }; + if ($@) { + log_warn("Failed to retrieve information about this node's CTs - $@"); + return; + } + + if (!defined($cts) || !scalar(@$cts)) { + log_skip("No containers on node detected."); + return; + } + my @running_vmids = map { $_->{status} eq 'running' ? $_->{vmid} : () } @$cts; + my @offline_vmids = map { $_->{status} ne 'running' ? $_->{vmid} : () } @$cts; + + my $legacy_container=0; + + for my $ctid (@running_vmids) { + my $pid = eval { PVE::LXC::find_lxc_pid($ctid) }; + if (my $err = $@) { + log_warn("Failed to get PID for running CT $ctid - $err"); + next; + } + my $rootdir = "/proc/$pid/root"; + my $conf = PVE::LXC::Config->load_config($ctid); + my $lxc_setup = PVE::LXC::Setup->new($conf, $rootdir); + if (!$lxc_setup->unified_cgroupv2_support()) { + log_warn("CT $ctid does not support running in a unified cgroup v2 layout - either " . + "upgrade it or set systemd.unified_cgroup_hierarchy=0 in the kernel cmdline - " . + "skipping further checks"); + return; + } + } + + my $storage_cfg = PVE::Storage::config(); + for my $ctid (@offline_vmids) { + my ($conf, $rootdir, $lxc_setup); + eval { + $conf = PVE::LXC::Config->load_config($ctid); + $rootdir = PVE::LXC::mount_all($ctid, $storage_cfg, $conf); + $lxc_setup = PVE::LXC::Setup->new($conf, $rootdir); + }; + if (my $err = $@) { + log_warn("Failed to load config and mount CT $ctid - $err"); + eval { PVE::LXC::umount_all($ctid, $storage_cfg, $conf) }; + next; + } + if (!$lxc_setup->unified_cgroupv2_support()) { + log_warn("CT $ctid does not support running in a unified cgroup v2 layout - either " . + "upgrade it or set systemd.unified_cgroup_hierarchy=0 in the kernel cmdline - " . + "skipping further checks"); + eval { PVE::LXC::umount_all($ctid, $storage_cfg, $conf) }; + last; + } + + eval { PVE::LXC::umount_all($ctid, $storage_cfg, $conf) }; + } +}; sub check_misc { print_header("MISCELLANEOUS CHECKS"); @@ -986,6 +1053,7 @@ sub check_misc { check_custom_pool_roles(); check_description_lengths(); check_storage_content(); + check_containers_cgroup_compat(); } __PACKAGE__->register_method ({ -- 2.30.2