From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <s.ivanov@proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 5919B72A8C for <pve-devel@lists.proxmox.com>; Fri, 2 Jul 2021 20:22:09 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 57284C0C4 for <pve-devel@lists.proxmox.com>; Fri, 2 Jul 2021 20:22:09 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id C697DC0BA for <pve-devel@lists.proxmox.com>; Fri, 2 Jul 2021 20:22:08 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id A01834051A for <pve-devel@lists.proxmox.com>; Fri, 2 Jul 2021 20:22:08 +0200 (CEST) From: Stoiko Ivanov <s.ivanov@proxmox.com> To: pve-devel@lists.proxmox.com Date: Fri, 2 Jul 2021 20:21:50 +0200 Message-Id: <20210702182152.485913-1-s.ivanov@proxmox.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.291 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment KAM_NUMSUBJECT 0.5 Subject ends in numbers excluding current years SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [setup.pm, pve6to7.pm, base.pm] Subject: [pve-devel] [PATCH manger/container] detect containers not supporting pure cgroupv2 X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/> List-Post: <mailto:pve-devel@lists.proxmox.com> List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe> X-List-Received-Date: Fri, 02 Jul 2021 18:22:09 -0000 This series addresses the issue of running containers, which boot with a systemd version which is too old (<232) to support the unified cgroup hierarchy - This includes CentOS 7 and Ubuntu 16.04 containers. The patch for pve-container simply logs to syslog with level err to notify the user. Since container start runs through our stack into systemd (and back into our stack), I did not see a better option (grateful for feedback if there is of course). One alternative might be to mount the container once in vm_start (or the API calls), check and unmount again - but this seemed a bit expensive to do unconditionally on every start. The patch for pve6to7 simply loops through all containers and checks for the condition pve-container: Stoiko Ivanov (1): prestart-hook: detect cgroupv2 incompatible systemd version src/PVE/LXC/Setup.pm | 8 ++++++++ src/PVE/LXC/Setup/Base.pm | 36 ++++++++++++++++++++++++++++++++++++ src/lxc-pve-prestart-hook | 7 +++++++ 3 files changed, 51 insertions(+) pve-manager: Stoiko Ivanov (1): pve6to7: check for containers not supporting pure cgroupv2 PVE/CLI/pve6to7.pm | 68 ++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 68 insertions(+) -- 2.30.2