From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 5A36572462 for ; Thu, 1 Jul 2021 14:42:53 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 572B924C81 for ; Thu, 1 Jul 2021 14:42:23 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 8D96724C36 for ; Thu, 1 Jul 2021 14:42:21 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 68D8F40345 for ; Thu, 1 Jul 2021 14:42:21 +0200 (CEST) From: Dominik Csapak To: pve-devel@lists.proxmox.com Date: Thu, 1 Jul 2021 14:25:06 +0200 Message-Id: <20210701122506.503289-8-d.csapak@proxmox.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20210701122506.503289-1-d.csapak@proxmox.com> References: <20210701122506.503289-1-d.csapak@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.704 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH manager 6/6] ui: Workspace: use domains info to hide password/tfa items X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 01 Jul 2021 12:42:53 -0000 in the user menu we have to make an additional api call here, since it is the only place (currently) where we can get the realm type Signed-off-by: Dominik Csapak --- alternatively, we could give that info in the index or the ticket api call, but this has the advantage that we will load the domains and can add them to the acl list (not included in this series, would send that when this gets applied) www/manager6/Workspace.js | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+) diff --git a/www/manager6/Workspace.js b/www/manager6/Workspace.js index b93ba669..066d46b6 100644 --- a/www/manager6/Workspace.js +++ b/www/manager6/Workspace.js @@ -172,6 +172,23 @@ Ext.define('PVE.StdWorkspace', { } }, }); + + Proxmox.Utils.API2Request({ + url: '/access/domains', + method: 'GET', + success: function(response) { + let [_username, realm] = PVE.Utils.parse_userid(Proxmox.UserName); + response.result.data.forEach((domain) => { + if (domain.realm === realm) { + let schema = PVE.Utils.authSchema[domain.type]; + if (schema) { + me.query('#tfaitem')[0].setHidden(!schema.tfa); + me.query('#passworditem')[0].setHidden(!schema.pwchange); + } + } + }); + }, + }); } }, @@ -353,6 +370,7 @@ Ext.define('PVE.StdWorkspace', { }, { text: gettext('Password'), + itemId: 'passworditem', iconCls: 'fa fa-fw fa-key', handler: function() { var win = Ext.create('Proxmox.window.PasswordEdit', { @@ -363,6 +381,7 @@ Ext.define('PVE.StdWorkspace', { }, { text: 'TFA', + itemId: 'tfaitem', iconCls: 'fa fa-fw fa-lock', handler: function(btn, event, rec) { var win = Ext.create('PVE.window.TFAEdit', { -- 2.30.2