From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 41ABE71EDC for ; Wed, 30 Jun 2021 17:15:02 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 3E3691B6C5 for ; Wed, 30 Jun 2021 17:15:02 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id B87DE1B6BB for ; Wed, 30 Jun 2021 17:15:01 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 8EB9446767 for ; Wed, 30 Jun 2021 17:15:01 +0200 (CEST) From: Dominik Csapak To: pve-devel@lists.proxmox.com Date: Wed, 30 Jun 2021 17:14:55 +0200 Message-Id: <20210630151459.231895-2-d.csapak@proxmox.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20210630151459.231895-1-d.csapak@proxmox.com> References: <20210630151459.231895-1-d.csapak@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.715 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH widget-toolkit 1/5] APTRepositories: change separation style between panels X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 30 Jun 2021 15:15:02 -0000 having double borders does not look so nice, separate them with a bit of padding also change the warning panel to a simple header Signed-off-by: Dominik Csapak --- src/node/APTRepositories.js | 17 ++++++++++++++--- 1 file changed, 14 insertions(+), 3 deletions(-) diff --git a/src/node/APTRepositories.js b/src/node/APTRepositories.js index 6812d46..7544a23 100644 --- a/src/node/APTRepositories.js +++ b/src/node/APTRepositories.js @@ -24,6 +24,8 @@ Ext.define('Proxmox.node.APTRepositoriesErrors', { store: {}, + border: false, + viewConfig: { stripeRows: false, getRowClass: () => 'proxmox-invalid-row', @@ -52,6 +54,8 @@ Ext.define('Proxmox.node.APTRepositoriesGrid', { cls: 'proxmox-apt-repos', // to allow applying styling to general components with local effect + border: false, + tbar: [ { text: gettext('Reload'), @@ -350,18 +354,25 @@ Ext.define('Proxmox.node.APTRepositories', { items: [ { - title: gettext('Warning'), - name: 'repositoriesMainWarning', - xtype: 'panel', + xtype: 'header', + baseCls: 'x-panel-header', bind: { + hidden: '{!mainWarning}', title: '{mainWarning}', + }, + }, + { + xtype: 'box', + bind: { hidden: '{!mainWarning}', }, + height: 5, }, { xtype: 'proxmoxNodeAPTRepositoriesErrors', name: 'repositoriesErrors', hidden: true, + padding: '0 0 5 0', bind: { hidden: '{noErrors}', }, -- 2.30.2