From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 61E9D70903 for ; Thu, 24 Jun 2021 17:11:41 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 4EE87F0F5 for ; Thu, 24 Jun 2021 17:11:41 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id B5746F0EC for ; Thu, 24 Jun 2021 17:11:40 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 7C01542F6E for ; Thu, 24 Jun 2021 17:11:40 +0200 (CEST) From: Dominik Csapak To: pve-devel@lists.proxmox.com Date: Thu, 24 Jun 2021 17:11:39 +0200 Message-Id: <20210624151139.23052-1-d.csapak@proxmox.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.733 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH manager] ui: panel/GuestStatusView: readd necessary xtypes X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 24 Jun 2021 15:11:41 -0000 currently, cbind only applies properties on objects which have an 'xtype' property. commit 38e6634a8fe8c11ec23e555ce55bc1972ccb5ea1 removed those, thinking the xtype in the 'defaults' is enough add them back, noting that cbind does need it, to prevent removal Signed-off-by: Dominik Csapak --- we should probably cherry-pick it into stable-6 as well www/manager6/panel/GuestStatusView.js | 2 ++ 1 file changed, 2 insertions(+) diff --git a/www/manager6/panel/GuestStatusView.js b/www/manager6/panel/GuestStatusView.js index 8db1f492..d59476c1 100644 --- a/www/manager6/panel/GuestStatusView.js +++ b/www/manager6/panel/GuestStatusView.js @@ -53,6 +53,7 @@ Ext.define('PVE.panel.GuestStatusView', { itemId: 'node', iconCls: 'fa fa-building fa-fw', title: gettext('Node'), + xtype: 'pmxInfoWidget', // necessary for cbind to apply cbind: { text: '{pveSelNode.data.node}', }, @@ -86,6 +87,7 @@ Ext.define('PVE.panel.GuestStatusView', { title: gettext('SWAP usage'), valueField: 'swap', maxField: 'maxswap', + xtype: 'pmxInfoWidget', // necessary for cbind to apply cbind: { hidden: '{isQemu}', disabled: '{isQemu}', -- 2.20.1