From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id CB7857579F for ; Thu, 24 Jun 2021 09:29:49 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id C829412ECF for ; Thu, 24 Jun 2021 09:29:49 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 0A86012EC4 for ; Thu, 24 Jun 2021 09:29:49 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id C40BB45B86 for ; Thu, 24 Jun 2021 09:29:43 +0200 (CEST) From: =?UTF-8?q?Fabian=20Gr=C3=BCnbichler?= To: pve-devel@lists.proxmox.com Date: Thu, 24 Jun 2021 09:29:36 +0200 Message-Id: <20210624072936.723195-1-f.gruenbichler@proxmox.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.639 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH installer] network: sync option names with pve-common X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 24 Jun 2021 07:29:49 -0000 back in 2018, commit 1accc6da659d8a02dcf1c2a636749e6f48fb9c2d "Inotify : write network config : use modern syntax for options" changed pve-common's /etc/network/interfaces writer to prefer options with '-' over those with '_'. having the installer write the old variant makes any modification of the vmbr0 interface via the API also change these three lines to the new variant - so let's do it right from the start. Signed-off-by: Fabian Grünbichler --- https://forum.proxmox.com/threads/wrong-elaboration-of-etc-network-interface-by-proxmox-gui.91271/ proxinstall | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/proxinstall b/proxinstall index d18ad6c..98cee66 100755 --- a/proxinstall +++ b/proxinstall @@ -1627,9 +1627,9 @@ sub extract_data { "\nauto vmbr0\niface vmbr0 $ntype static\n" . "\taddress $cidr\n" . "\tgateway $gateway\n" . - "\tbridge_ports $ethdev\n" . - "\tbridge_stp off\n" . - "\tbridge_fd 0\n"; + "\tbridge-ports $ethdev\n" . + "\tbridge-stp off\n" . + "\tbridge-fd 0\n"; } else { $ifaces .= "auto $ethdev\n" . "iface $ethdev $ntype static\n" . -- 2.30.2