From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 3EED175190 for ; Wed, 23 Jun 2021 14:32:08 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 2E9D8ADF3 for ; Wed, 23 Jun 2021 14:31:38 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id B3645ADE8 for ; Wed, 23 Jun 2021 14:31:37 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id BA44846778 for ; Wed, 23 Jun 2021 14:31:36 +0200 (CEST) Date: Wed, 23 Jun 2021 14:31:36 +0200 From: Wolfgang Bumiller To: Fabian =?utf-8?Q?Gr=C3=BCnbichler?= Cc: Proxmox VE development discussion Message-ID: <20210623123136.6i5n6wcrypcropqi@olga.proxmox.com> References: <20210622121828.84178-1-w.bumiller@proxmox.com> <20210622121828.84178-7-w.bumiller@proxmox.com> <1624445772.h08o0zhckv.astroid@nora.none> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1624445772.h08o0zhckv.astroid@nora.none> X-SPAM-LEVEL: Spam detection results: 0 AWL 0.777 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH v2 container 1/3] migration: fix snapshots boolean accounting X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 Jun 2021 12:32:08 -0000 On Wed, Jun 23, 2021 at 12:59:58PM +0200, Fabian Grünbichler wrote: > some indication on what was broken would be nice.. > > AFAICT, storage_migrate fixes this to a boolean anyway, and this is only > passed to storage_migrate, so.. !? The type is not the problem. It's assigned - as in overwritten - in each check, and it's called last for the current state, so this was always set to false. > > On June 22, 2021 2:18 pm, Wolfgang Bumiller wrote: > > Signed-off-by: Wolfgang Bumiller > > --- > > No changes to v1. > > > > src/PVE/LXC/Migrate.pm | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/src/PVE/LXC/Migrate.pm b/src/PVE/LXC/Migrate.pm > > index 3cd895d..ce1f7dd 100644 > > --- a/src/PVE/LXC/Migrate.pm > > +++ b/src/PVE/LXC/Migrate.pm > > @@ -146,7 +146,7 @@ sub phase1 { > > } > > > > $volhash->{$volid}->{ref} = defined($snapname) ? 'snapshot' : 'config'; > > - $volhash->{$volid}->{snapshots} = defined($snapname); > > + $volhash->{$volid}->{snapshots} = 1 if defined($snapname); > > > > my ($path, $owner) = PVE::Storage::path($self->{storecfg}, $volid); > > > > -- > > 2.30.2