From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 3A41174C60 for ; Tue, 22 Jun 2021 14:31:10 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 7DB5B2793B for ; Tue, 22 Jun 2021 14:30:39 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id B28A327930 for ; Tue, 22 Jun 2021 14:30:38 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 7ACF344B66 for ; Tue, 22 Jun 2021 14:30:38 +0200 (CEST) From: Lorenz Stechauner To: pve-devel@lists.proxmox.com Date: Tue, 22 Jun 2021 14:30:30 +0200 Message-Id: <20210622123030.2586071-1-l.stechauner@proxmox.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.717 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [qemuserver.pm] Subject: [pve-devel] [PATCH v4 qemu-server] vm_start: check if storages of volumes support correct content-type X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Jun 2021 12:31:10 -0000 Signed-off-by: Lorenz Stechauner --- changes to v3: * dropped already applied patch * moved check to cfg2cmd (with helper) * 'images' content-type is not anymore hard-coded vm state files are not included anymore and efi disks have type 'images' - therefore they should work PVE/QemuServer.pm | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm index fe31741..d8e2d44 100644 --- a/PVE/QemuServer.pm +++ b/PVE/QemuServer.pm @@ -3610,6 +3610,7 @@ sub config_to_command { my ($ds, $drive) = @_; if (PVE::Storage::parse_volume_id($drive->{file}, 1)) { + check_volume_storage_type($storecfg, $drive->{file}); push @$vollist, $drive->{file}; } @@ -7736,4 +7737,17 @@ sub vm_is_paused { return $qmpstatus && $qmpstatus->{status} eq "paused"; } +sub check_volume_storage_type { + my ($storecfg, $vol) = @_; + + my ($storeid, $volname) = PVE::Storage::parse_volume_id($vol); + my $scfg = PVE::Storage::storage_config($storecfg, $storeid); + my ($vtype) = PVE::Storage::parse_volname($storecfg, $vol); + + die "storage '$storeid' does not support content-type '$vtype'\n" + if !$scfg->{content}->{$vtype}; + + return 1; +} + 1; -- 2.30.2