From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 509B574B45 for ; Tue, 22 Jun 2021 11:57:57 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 4D7D42520D for ; Tue, 22 Jun 2021 11:57:27 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 3AF8325202 for ; Tue, 22 Jun 2021 11:57:26 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 1248F4302A for ; Tue, 22 Jun 2021 11:57:26 +0200 (CEST) From: Dominik Csapak To: pve-devel@lists.proxmox.com Date: Tue, 22 Jun 2021 11:57:25 +0200 Message-Id: <20210622095725.27282-1-d.csapak@proxmox.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.784 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH widget-toolkit] panel/JournalView: fix flickering in journal livemode X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Jun 2021 09:57:57 -0000 it seems that something changed in extjs 7 which does not quite restore the correct scroll position when the identical content is set on a component. this means that sometimes, we update the text with the identical one, but the scroll position is now off, only to scroll back to the bottom this causes a flickering everytime we do the api call. instead, only update the component when the content really changed. Signed-off-by: Dominik Csapak --- src/panel/JournalView.js | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/src/panel/JournalView.js b/src/panel/JournalView.js index 692f241..f672be1 100644 --- a/src/panel/JournalView.js +++ b/src/panel/JournalView.js @@ -77,6 +77,8 @@ Ext.define('Proxmox.panel.JournalView', { let num = lines.length; let text = lines.map(Ext.htmlEncode).join('
'); + let contentChanged = true; + if (!livemode) { if (num) { view.content = text; @@ -89,6 +91,8 @@ Ext.define('Proxmox.panel.JournalView', { view.content = view.content ? text + '
' + view.content : text; } else if (!top && num) { view.content = view.content ? view.content + '
' + text : text; + } else { + contentChanged = false; } // update cursors @@ -101,7 +105,9 @@ Ext.define('Proxmox.panel.JournalView', { } } - contentEl.update(view.content); + if (contentChanged) { + contentEl.update(view.content); + } me.updateScroll(livemode, num, scrollPos, scrollPosTop); }, -- 2.20.1