From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 51E8774672 for ; Mon, 21 Jun 2021 18:36:21 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 36A0A1EE18 for ; Mon, 21 Jun 2021 18:35:51 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 16D361EDFD for ; Mon, 21 Jun 2021 18:35:49 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id D6C7E42F37 for ; Mon, 21 Jun 2021 18:35:48 +0200 (CEST) From: Stefan Reiter To: pve-devel@lists.proxmox.com Date: Mon, 21 Jun 2021 18:35:41 +0200 Message-Id: <20210621163542.1752647-2-s.reiter@proxmox.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20210621163542.1752647-1-s.reiter@proxmox.com> References: <20210621163542.1752647-1-s.reiter@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.733 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH qemu-server 1/2] use KillMode 'process' for systemd scope X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 Jun 2021 16:36:21 -0000 KillMode 'none' is deprecated, and systemd loudly complains about that in the journal. To avoid the warning, but keep the behaviour the same, use KillMode 'process'. This mode does two things differently, which we have to stop it from doing: * it sends SIGTERM right when the scope is cancelled (e.g. on shutdown) -> but only to the "root" process, which in our case is the worker instance forking QEMU, so it is already dead by the time this happens * it sends SIGKILL to *all* children after a timeout -> can be avoided by setting either SendSIGKILL to false, or TimeoutStopUSec to infinity - for safety, we do both In my testing, this replicated the previous behaviour exactly, but without using the deprecated 'none' mode. Signed-off-by: Stefan Reiter --- Depends on updated pve-common from patch 2. PVE/QemuServer.pm | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm index 07dd14a..d5b7ead 100644 --- a/PVE/QemuServer.pm +++ b/PVE/QemuServer.pm @@ -5286,7 +5286,9 @@ sub vm_start_nolock { my %properties = ( Slice => 'qemu.slice', - KillMode => 'none' + KillMode => 'process', + SendSIGKILL => 0, + TimeoutStopUSec => ULONG_MAX, # infinity ); if (PVE::CGroup::cgroup_mode() == 2) { -- 2.30.2