From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id B234C74496 for ; Mon, 21 Jun 2021 15:56:20 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 8B7091C3EA for ; Mon, 21 Jun 2021 15:55:40 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id E501F1C30D for ; Mon, 21 Jun 2021 15:55:36 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id BBF6942F14 for ; Mon, 21 Jun 2021 15:55:36 +0200 (CEST) From: Dominik Csapak To: pve-devel@lists.proxmox.com Date: Mon, 21 Jun 2021 15:55:26 +0200 Message-Id: <20210621135534.14807-14-d.csapak@proxmox.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20210621135534.14807-1-d.csapak@proxmox.com> References: <20210621135534.14807-1-d.csapak@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.840 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH qemu-server 7/7] PVE/QemuMigrate: check for mapped resources on migration X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 Jun 2021 13:56:20 -0000 they can only be migrated to nodes where there exists a mapping, and if offline Signed-off-by: Dominik Csapak --- PVE/QemuMigrate.pm | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/PVE/QemuMigrate.pm b/PVE/QemuMigrate.pm index 5f37890..6ae365d 100644 --- a/PVE/QemuMigrate.pm +++ b/PVE/QemuMigrate.pm @@ -323,7 +323,7 @@ sub prepare { } } - my $loc_res = PVE::QemuServer::check_local_resources($conf, 1); + my ($loc_res, $mapped_res, $not_allowed_nodes) = PVE::QemuServer::check_local_resources($conf, 1); if (scalar @$loc_res) { if ($self->{running} || !$self->{opts}->{force}) { die "can't migrate VM which uses local devices: " . join(", ", @$loc_res) . "\n"; @@ -332,6 +332,17 @@ sub prepare { } } + if (scalar @$mapped_res) { + my $not_available = $not_allowed_nodes->{$self->{node}}; + if ($self->{running}) { + die "can't migrate running VM which uses mapped devices: " . join(", ", @$mapped_res) . "\n"; + } elsif (scalar @$not_available) { + die "can't migrate to '$self->{node}': missing mapped devices" . join(", ", @$not_available) . "\n"; + } else { + $self->log('info', "migrating VM which uses mapped local devices"); + } + } + my $vollist = PVE::QemuServer::get_vm_volumes($conf); foreach my $volid (@$vollist) { -- 2.20.1