From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 70B067426E for ; Mon, 21 Jun 2021 10:41:39 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 5D12019C31 for ; Mon, 21 Jun 2021 10:41:09 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id EBD3919C25 for ; Mon, 21 Jun 2021 10:41:08 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id BAB8740818 for ; Mon, 21 Jun 2021 10:41:08 +0200 (CEST) Date: Mon, 21 Jun 2021 10:41:08 +0200 From: Wolfgang Bumiller To: Fabian Ebner Cc: pve-devel@lists.proxmox.com Message-ID: <20210621084108.vjilobjck6kme4hb@olga.proxmox.com> References: <20210402123636.27037-1-f.ebner@proxmox.com> <62c7149e-d029-295f-2a38-102fae14889a@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <62c7149e-d029-295f-2a38-102fae14889a@proxmox.com> X-SPAM-LEVEL: Spam detection results: 0 AWL 0.841 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH container] fix #3367: skip bind mounts when converting to template X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 Jun 2021 08:41:39 -0000 On Tue, Apr 06, 2021 at 08:26:50AM +0200, Fabian Ebner wrote: > It turns out that we do not yet allow cloning from container templates with > bind mounts. So in a sense container templates with bind mounts are > currently misconfigured, and this patch would make it easier to get there... > > Should I send a v2 with a patch making cloning from such templates possible, > or were there some concerns to not allow it in the first place? There is a > # TODO: allow bind mounts? > comment in the clone API call. It's mostly that bind mounts are generally root-only. Silently dropping them when converting to a template seems awkward, I'd rather have this throw an error, too. (Also remember that containers don't need to be templates to be cloned.)