From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 9B375737F3 for ; Fri, 18 Jun 2021 13:34:10 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 91A832708C for ; Fri, 18 Jun 2021 13:34:10 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 1E83F27082 for ; Fri, 18 Jun 2021 13:34:10 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id E0BB444207 for ; Fri, 18 Jun 2021 13:34:09 +0200 (CEST) From: Dominik Csapak To: pve-devel@lists.proxmox.com Date: Fri, 18 Jun 2021 13:34:09 +0200 Message-Id: <20210618113409.32548-1-d.csapak@proxmox.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.874 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH manager] ui: fix Guest Summary Notes height X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 18 Jun 2021 11:34:10 -0000 fixes 'infinite' height of the guest notes, by setting the height on the container a level up the notes view itself is already scrollable, so if it is too large, there'll be a scrollbar this does not change anything for templates, as there we show nothing under the notes and thus there the infinite height is ok Signed-off-by: Dominik Csapak --- should apply to stable-6 too if we want that www/manager6/panel/GuestStatusView.js | 2 -- www/manager6/panel/GuestSummary.js | 1 + 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/www/manager6/panel/GuestStatusView.js b/www/manager6/panel/GuestStatusView.js index 5929d9bf..8db1f492 100644 --- a/www/manager6/panel/GuestStatusView.js +++ b/www/manager6/panel/GuestStatusView.js @@ -3,8 +3,6 @@ Ext.define('PVE.panel.GuestStatusView', { alias: 'widget.pveGuestStatusView', mixins: ['Proxmox.Mixin.CBind'], - height: 300, - cbindData: function(initialConfig) { var me = this; return { diff --git a/www/manager6/panel/GuestSummary.js b/www/manager6/panel/GuestSummary.js index 7061b1a4..82cc7a7f 100644 --- a/www/manager6/panel/GuestSummary.js +++ b/www/manager6/panel/GuestSummary.js @@ -54,6 +54,7 @@ Ext.define('PVE.qemu.Summary', { items = [ { xtype: 'container', + height: 300, layout: { type: 'hbox', align: 'stretch', -- 2.20.1