From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 3D09C728D2 for ; Wed, 16 Jun 2021 09:27:40 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id D3367E8E3 for ; Wed, 16 Jun 2021 09:27:09 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 09543E7B7 for ; Wed, 16 Jun 2021 09:27:05 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id D739742896 for ; Wed, 16 Jun 2021 09:27:04 +0200 (CEST) From: Fabian Ebner To: pve-devel@lists.proxmox.com Date: Wed, 16 Jun 2021 09:27:00 +0200 Message-Id: <20210616072700.54289-9-f.ebner@proxmox.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20210616072700.54289-1-f.ebner@proxmox.com> References: <20210616072700.54289-1-f.ebner@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.595 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment POISEN_SPAM_PILL 0.1 Meta: its spam POISEN_SPAM_PILL_1 0.1 random spam to be learned in bayes POISEN_SPAM_PILL_3 0.1 random spam to be learned in bayes SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [cephfsplugin.pm] Subject: [pve-devel] [RFC v2 storage 5/5] cephfs: update reminder for systemd_netmount removal X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 16 Jun 2021 07:27:40 -0000 Commit d9ece228fbbbf0eb575c8a067a70ed7023078f84 introduced the workaround with using systemd units and 25e222ca0d96a0da0d491e749b437d2822215e9e re-used the functionality for fuse-mounts too. The latter commit suggests to switch to using mount.fuse.ceph for the '_netdev' option, but it doesn't seem to work: root@pve701 / # mount -t fuse.ceph 10.10.10.11,10.10.10.12,10.10.10.13:/ /mnttest/fuse -o 'ceph.id=admin,ceph.keyfile=/etc/pve/priv/ceph/cephfs.secret,ceph.conf=/etc/pve/ceph.conf,_netdev' ceph-fuse[20729]: starting ceph client 2021-06-15T14:22:00.631+0200 7f995f878080 -1 init, newargv = 0x55e09fc11a40 newargc=11 ceph-fuse[20729]: starting fuse root@pve701 / # mount -t ceph 10.10.10.11,10.10.10.12,10.10.10.13:/ /mnttest/normal -o 'name=admin,secretfile=/etc/pve/priv/ceph/cephfs.secret,conf=/etc/pve/ceph.conf,_netdev' root@pve701 / # mount | grep mnttest ceph-fuse on /mnttest/fuse type fuse.ceph-fuse (rw,nosuid,nodev,relatime,user_id=0,group_id=0,allow_other) 10.10.10.11,10.10.10.12,10.10.10.13:/ on /mnttest/normal type ceph (rw,relatime,name=admin,secret=,acl,_netdev) Also, the return value is not propagated by mount.fuse.ceph, meaning the output would need to be parsed... root@pve701 ~ # mount -t fuse.ceph 10.10.10.11,10.10.10.12,10.10.10.13:/ /mnttest/fuse -o 'ceph.id=admin,ceph.keyfile=/etc/pve/priv/ceph/cephfs.secret,ceph.conf=/etc/pve/ceph.conf,_netdev' 2021-06-15T14:42:56.326+0200 7f634edae080 -1 init, newargv = 0x560cdb5e0a40 newargc=11 ceph-fuse[34480]: starting ceph client fuse: mountpoint is not empty fuse: if you are sure this is safe, use the 'nonempty' mount option ceph-fuse[34480]: fuse failed to start 2021-06-15T14:42:56.338+0200 7f634edae080 -1 fuse_mount(mountpoint=/mnttest/fuse) failed. Mount failed with status code: 5 root@pve701 ~ # echo $? 0 Signed-off-by: Fabian Ebner --- New in v2. Hope I'm missing something and we can actually switch. PVE/Storage/CephFSPlugin.pm | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/PVE/Storage/CephFSPlugin.pm b/PVE/Storage/CephFSPlugin.pm index da64080..f919ab8 100644 --- a/PVE/Storage/CephFSPlugin.pm +++ b/PVE/Storage/CephFSPlugin.pm @@ -38,8 +38,7 @@ sub cephfs_is_mounted { return undef; } -# FIXME: remove in PVE 7.0 where systemd is recent enough to not have those -# local-fs/remote-fs dependency cycles generated for _netdev mounts... +# FIXME: remove once it's possible to specify _netdev for fuse.ceph mounts sub systemd_netmount { my ($where, $type, $what, $opts) = @_; -- 2.30.2