From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 9D29272103 for ; Mon, 14 Jun 2021 15:07:15 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 907BA250FB for ; Mon, 14 Jun 2021 15:07:15 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 7E5E4250F1 for ; Mon, 14 Jun 2021 15:07:11 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 475E842FAB for ; Mon, 14 Jun 2021 15:07:11 +0200 (CEST) From: Oguz Bektas To: pve-devel@lists.proxmox.com Date: Mon, 14 Jun 2021 15:07:03 +0200 Message-Id: <20210614130703.898312-1-o.bektas@proxmox.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 1.984 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH container] pct exec: add friendly warning in case container not running X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 14 Jun 2021 13:07:15 -0000 Signed-off-by: Oguz Bektas --- src/PVE/CLI/pct.pm | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/PVE/CLI/pct.pm b/src/PVE/CLI/pct.pm index 6b63915..ae5254c 100755 --- a/src/PVE/CLI/pct.pm +++ b/src/PVE/CLI/pct.pm @@ -189,6 +189,8 @@ __PACKAGE__->register_method ({ if (!@{$param->{'extra-args'}}) { die "missing command"; } + die "Error: container '$param->{vmid}' not running!\n" if !PVE::LXC::check_running($param->{vmid}); + exec('lxc-attach', '-n', $param->{vmid}, '--', @{$param->{'extra-args'}}); }}); -- 2.20.1