From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 52FDB7159E for ; Fri, 11 Jun 2021 09:28:20 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 4CD07E1EB for ; Fri, 11 Jun 2021 09:27:50 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id A39D0E1DD for ; Fri, 11 Jun 2021 09:27:48 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 7DFFE42357 for ; Fri, 11 Jun 2021 09:27:48 +0200 (CEST) Date: Fri, 11 Jun 2021 09:27:46 +0200 From: Dominic =?iso-8859-1?Q?J=E4ger?= To: Proxmox VE development discussion Message-ID: <20210611072746.GA40697@mala.proxmox.com> References: <20210517080318.51405-1-l.stechauner@proxmox.com> <20210517080318.51405-8-l.stechauner@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20210517080318.51405-8-l.stechauner@proxmox.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-SPAM-LEVEL: Spam detection results: 0 AWL 1.427 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [proxmox.com] Subject: Re: [pve-devel] [PATCH v6 manager 7/7] fix #1710: ui: storage: add download from url button X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 11 Jun 2021 07:28:20 -0000 On Mon, May 17, 2021 at 10:03:18AM +0200, Lorenz Stechauner wrote: > + iso: [ > + 'application/octet-stream', > + 'application/x-iso9660-image', > + 'application/x-ima', When I try do download a Proxmox VE image I get type x-cd-image. https://www.proxmox.com/en/downloads?task=callelement&format=raw&item_id=589&element=f85c494b-2b32-4109-b8c1-083cca2b7db6&method=download&args[0]=b9d30b3515e7a12dff5619ff1e1843be Then the download button should not be deactivated. > + advancedColumn1: [ > + { > + xtype: 'textfield', > + name: 'checksum', > + fieldLabel: gettext('Checksum'), > + allowBlank: true, > + disabled: true, > + emptyText: gettext('none'), > + id: 'downloadUrlChecksum', > + }, > + { > + xtype: 'pveHashAlgorithmSelector', > + name: 'checksum-algorithm', > + fieldLabel: gettext('Hash algorithm'), > + allowBlank: true, > + hasNoneOption: true, > + value: '__default__', > + listeners: { > + change: 'hashChange', > + }, > + }, An algorithm must be selected before entering something into the textfield. Therefore, I'd place the algorithm selector above/before the textfield. > + ], > + advancedColumn2: [ > + { > + xtype: 'textfield', > + fieldLabel: gettext('MIME type'), > + name: 'mimetype', > + disabled: true, > + editable: false, Non-editable might be good in general, but I cannot download the PVE image with (unsupported) type x-cd-image because it will remain invalid forever. > + emptyText: gettext('unknown'), > + listeners: { > + change: 'typeChange', > + }, > + }, > + { > + xtype: 'proxmoxcheckbox', > + name: 'verify-certificates', > + fieldLabel: gettext('Verify certificates'), > + uncheckedValue: 0, > + checked: true, > + listeners: { > + change: 'urlChange', > + }, > + }, > + ], > + }, > + ], > + Downloading a Debian image and verifying with SHA512 worked for me https://cdimage.debian.org/debian-cd/current/amd64/iso-dvd/debian-10.9.0-amd64-DVD-1.iso Tested-by: Dominic Jäger