From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 231EC70796 for ; Mon, 7 Jun 2021 13:49:49 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 1143A10A73 for ; Mon, 7 Jun 2021 13:49:19 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 4F90A10A3B for ; Mon, 7 Jun 2021 13:49:14 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 2760F40348 for ; Mon, 7 Jun 2021 13:49:14 +0200 (CEST) From: Stefan Reiter To: pve-devel@lists.proxmox.com Date: Mon, 7 Jun 2021 13:48:50 +0200 Message-Id: <20210607114850.964814-3-s.reiter@proxmox.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20210607114850.964814-1-s.reiter@proxmox.com> References: <20210607114850.964814-1-s.reiter@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.919 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH qemu-server 2/2] enable io-uring support X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 07 Jun 2021 11:49:49 -0000 Note that the value in this enum directly represents the value passed to QEMU, so we need to use the underscore. Off by default, updated QEMU required, but no compatibility issues, as this is a new value that wasn't valid before, and setting it is the users choice. Signed-off-by: Stefan Reiter --- We probably want this in the GUI as well, there isn't even an option for 'aio' in general atm. Thought I'd send it out without just for testing and getting the conversation going. On a side note, I feel like exposing an option called "threads" when we already have "iothread" as well might get confusing. Also, if it works well, we could probably make this the default later (probably not a great idea for 7.0 though?). PVE/QemuServer/Drive.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/PVE/QemuServer/Drive.pm b/PVE/QemuServer/Drive.pm index 146a4ab..82a6bfe 100644 --- a/PVE/QemuServer/Drive.pm +++ b/PVE/QemuServer/Drive.pm @@ -116,7 +116,7 @@ my %drivedesc_base = ( }, aio => { type => 'string', - enum => [qw(native threads)], + enum => [qw(native threads io_uring)], description => 'AIO type to use.', optional => 1, }, -- 2.30.2