From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 2266370760 for ; Mon, 7 Jun 2021 12:32:07 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 1322210045 for ; Mon, 7 Jun 2021 12:32:07 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 3E49C1003C for ; Mon, 7 Jun 2021 12:32:03 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 1930E4292A for ; Mon, 7 Jun 2021 12:32:03 +0200 (CEST) From: Dominik Csapak To: pve-devel@lists.proxmox.com Date: Mon, 7 Jun 2021 12:31:58 +0200 Message-Id: <20210607103158.21038-1-d.csapak@proxmox.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.982 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH manager] ui: ceph/Pools: defuse min_size warning X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 07 Jun 2021 10:32:07 -0000 we should not warn for the ceph built-in default warnings for min_size having the min_size half of the size (rounded up) is ok and even the default for ceph since there seems to be no 'quorum based' pg inconsistency recovery[0], only a copy from the authoritative osd, there is nothing wrong with setting that. 0: https://docs.ceph.com/en/latest/rados/operations/pg-repair/ Signed-off-by: Dominik Csapak --- www/manager6/ceph/Pool.js | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/www/manager6/ceph/Pool.js b/www/manager6/ceph/Pool.js index 41c08c39..41df216e 100644 --- a/www/manager6/ceph/Pool.js +++ b/www/manager6/ceph/Pool.js @@ -28,7 +28,7 @@ Ext.define('PVE.CephPoolInputPanel', { allowBlank: false, listeners: { change: function(field, val) { - let size = Math.round((val + 1) / 2); + let size = Math.round(val / 2); if (size > 1) { field.up('inputpanel').down('field[name=min_size]').setValue(size); } @@ -82,7 +82,7 @@ Ext.define('PVE.CephPoolInputPanel', { let panel = field.up('inputpanel'); let size = panel.down('field[name=size]').getValue(); - let showWarning = minSize <= size / 2 && minSize !== size; + let showWarning = minSize < (size / 2) && minSize !== size; let fieldLabel = gettext('Min. Size'); if (showWarning) { @@ -97,7 +97,7 @@ Ext.define('PVE.CephPoolInputPanel', { xtype: 'displayfield', name: 'min_size-warning', userCls: 'pmx-hint', - value: gettext('min_size <= size/2 can lead to data loss, incomplete PGs or unfound objects.'), + value: gettext('min_size < size/2 can lead to data loss, incomplete PGs or unfound objects.'), hidden: true, }, { -- 2.20.1