From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 05E247450F for ; Tue, 1 Jun 2021 18:10:28 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id DDA522B6E6 for ; Tue, 1 Jun 2021 18:10:27 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 816542B6A9 for ; Tue, 1 Jun 2021 18:10:26 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 554B246590 for ; Tue, 1 Jun 2021 18:10:26 +0200 (CEST) From: Aaron Lauterer To: pve-devel@lists.proxmox.com Date: Tue, 1 Jun 2021 18:10:18 +0200 Message-Id: <20210601161025.32024-1-a.lauterer@proxmox.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.041 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [drive.pm, lvmthinplugin.pm, qm.pm, zfspoolplugin.pm, pct.pm, qemu.pm, lxc.pm, rbdplugin.pm, lvmplugin.pm, plugin.pm, proxmox.com, storage.pm] Subject: [pve-devel] [RFC series 0/7] move disk or volume to other guests X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 Jun 2021 16:10:28 -0000 This is the continuation of 'disk-reassign' but instead of a separate API endpoint we now follow the approach to make it part of the 'move-disk' and 'move-volume' endpoints for VMs and containers. The main idea is to make it easy to move a disk/volume to another guest. Currently this is a manual and error prone process that requires knowledge of how PVE handles disks/volumes and the mapping which guest they belong to. With this, the 'qm move-disk' and 'pct move-volume' are changed in the way that the storage parameter is optional as well as the new target-vmid and target-{disk,mp}. This will keep old calls to move the disk/volume to another storage working. To move to another guest, the storage needs to be omitted. Major changes since the last patches and discussions [0] are that the storage layer only implements the renaming itself. The layer above (qemu-server and pve-container) define the name of the new volume/disk. Therefore it was necessary to expose the 'find_free_diskname' function. The rename function on the storage layer handles possible template referneces and the creation of the new volid as that is highly dependent on the actual storage. The following storage types are implemented at the moment: * dir based ones * ZFS * (thin) LVM * Ceph RBD Most parts of the disk-reassign code has been taken and moved into the 'move_disk' and 'move_volume' endpoints with conditional checking if the reassign code or the move to other storage code is meant to run depending on the given parameters. As this is the first iteration of this, I am happy about feedback if this is the right direction that I am taking and what I might have missed. [0] https://lists.proxmox.com/pipermail/pve-devel/2021-April/047481.html [1] https://lists.proxmox.com/pipermail/pve-devel/2021-April/047481.html storage: Aaron Lauterer (2): storage: expose find_free_diskname add disk rename feature PVE/Storage.pm | 27 +++++++++++++++++++++++++-- PVE/Storage/LVMPlugin.pm | 18 ++++++++++++++++++ PVE/Storage/LvmThinPlugin.pm | 1 + PVE/Storage/Plugin.pm | 29 +++++++++++++++++++++++++++++ PVE/Storage/RBDPlugin.pm | 16 ++++++++++++++++ PVE/Storage/ZFSPoolPlugin.pm | 12 ++++++++++++ 6 files changed, 101 insertions(+), 2 deletions(-) qemu-server: Aaron Lauterer (3): cli: qm: change move_disk to move-disk Drive: add valid_drive_names_with_unused api: move-disk: add move to other VM PVE/API2/Qemu.pm | 204 +++++++++++++++++++++++++++++++++++++++- PVE/CLI/qm.pm | 3 +- PVE/QemuServer/Drive.pm | 4 + 3 files changed, 205 insertions(+), 6 deletions(-) container: Aaron Lauterer (2): cli: pct: change move_volume to move-volume api: move-volume: add move to another container src/PVE/API2/LXC.pm | 229 ++++++++++++++++++++++++++++++++++++++++---- src/PVE/CLI/pct.pm | 3 +- 2 files changed, 210 insertions(+), 22 deletions(-) -- 2.20.1