From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 19717733C3 for ; Thu, 27 May 2021 14:24:32 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 1328D1D8A1 for ; Thu, 27 May 2021 14:24:02 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 6536E1D88F for ; Thu, 27 May 2021 14:24:01 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 144AE466B3 for ; Thu, 27 May 2021 14:24:01 +0200 (CEST) From: Lorenz Stechauner To: pve-devel@lists.proxmox.com Date: Thu, 27 May 2021 14:23:31 +0200 Message-Id: <20210527122331.86302-3-l.stechauner@proxmox.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20210527122331.86302-1-l.stechauner@proxmox.com> References: <20210527122331.86302-1-l.stechauner@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.326 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH v3 qemu-server 1/1] vm_start: check if storages of volumes support content images X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 27 May 2021 12:24:32 -0000 it is now necessary for storages to support the 'images' content in order to start vms on them. all native storage plugins already report the images content correctly. Signed-off-by: Lorenz Stechauner --- PVE/QemuServer.pm | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm index 0bfbca4..3b656a1 100644 --- a/PVE/QemuServer.pm +++ b/PVE/QemuServer.pm @@ -5124,6 +5124,13 @@ sub vm_start_nolock { my ($cmd, $vollist, $spice_port) = config_to_command($storecfg, $vmid, $conf, $defaults, $forcemachine, $forcecpu, $params->{'pbs-backing'}); + for my $vol (@$vollist) { + if (my ($storeid, $volname) = PVE::Storage::parse_volume_id($vol, 1)) { + my $scfg = PVE::Storage::storage_config($storecfg, $storeid); + die "storage '$storeid' does not support vm disks\n" if !$scfg->{content}->{images}; + } + } + my $migration_ip; my $get_migration_ip = sub { my ($nodename) = @_; -- 2.20.1