From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id D7BE47327F for ; Thu, 27 May 2021 11:26:15 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id C80931BB4D for ; Thu, 27 May 2021 11:26:15 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id D35581BAC7 for ; Thu, 27 May 2021 11:26:14 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id AD54146641 for ; Thu, 27 May 2021 11:26:14 +0200 (CEST) From: Oguz Bektas To: pve-devel@lists.proxmox.com Date: Thu, 27 May 2021 11:26:01 +0200 Message-Id: <20210527092601.148400-3-o.bektas@proxmox.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20210527092601.148400-1-o.bektas@proxmox.com> References: <20210527092601.148400-1-o.bektas@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 1 AWL 1.091 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH v3 container 2/2] clear machine-id also after container clone X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 27 May 2021 09:26:15 -0000 pass $clone=1 to avoid removing the file. instead we truncate it to an empty file Signed-off-by: Oguz Bektas --- v2->v3: * clear machine-id at the end of clone task worker src/PVE/API2/LXC.pm | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/src/PVE/API2/LXC.pm b/src/PVE/API2/LXC.pm index a9ea3a6..d5c12dc 100644 --- a/src/PVE/API2/LXC.pm +++ b/src/PVE/API2/LXC.pm @@ -1590,6 +1590,12 @@ __PACKAGE__->register_method({ die "clone failed: $err"; } + my $lastconf = PVE::LXC::Config->load_config($newid); + my $rootdir = PVE::LXC::mount_all($newid, $storecfg, $lastconf, 1); + my $lxc_setup = PVE::LXC::Setup->new($lastconf, $rootdir); + $lxc_setup->clear_machine_id($lastconf, 1); + PVE::LXC::umount_all($newid, $storecfg, $lastconf, 1); + return; }; -- 2.20.1