From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id DFC6C72A2E for ; Wed, 26 May 2021 10:59:17 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 881C3E519 for ; Wed, 26 May 2021 10:58:47 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 93C0DE2ED for ; Wed, 26 May 2021 10:58:41 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 6DC464666D for ; Wed, 26 May 2021 10:58:41 +0200 (CEST) From: Dominik Csapak To: pve-devel@lists.proxmox.com Date: Wed, 26 May 2021 10:58:36 +0200 Message-Id: <20210526085839.9808-9-d.csapak@proxmox.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20210526085839.9808-1-d.csapak@proxmox.com> References: <20210526085839.9808-1-d.csapak@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.037 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH widget-toolkit 08/11] Toolkit: remove firefox touchscreen override X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 26 May 2021 08:59:17 -0000 seems to be fixed, at least i could not reproduce here. If users report this again, we can still revert it if necessary. Signed-off-by: Dominik Csapak --- src/Toolkit.js | 43 ------------------------------------------- 1 file changed, 43 deletions(-) diff --git a/src/Toolkit.js b/src/Toolkit.js index b85cd32..ba06a33 100644 --- a/src/Toolkit.js +++ b/src/Toolkit.js @@ -184,49 +184,6 @@ Ext.apply(Ext.form.field.VTypes, { }, }); -// Firefox 52+ Touchscreen bug -// see https://www.sencha.com/forum/showthread.php?336762-Examples-don-t-work-in-Firefox-52-touchscreen/page2 -// and https://bugzilla.proxmox.com/show_bug.cgi?id=1223 -Ext.define('EXTJS_23846.Element', { - override: 'Ext.dom.Element', -}, function(Element) { - let supports = Ext.supports, - proto = Element.prototype, - eventMap = proto.eventMap, - additiveEvents = proto.additiveEvents; - - if (Ext.os.is.Desktop && supports.TouchEvents && !supports.PointerEvents) { - eventMap.touchstart = 'mousedown'; - eventMap.touchmove = 'mousemove'; - eventMap.touchend = 'mouseup'; - eventMap.touchcancel = 'mouseup'; - - additiveEvents.mousedown = 'mousedown'; - additiveEvents.mousemove = 'mousemove'; - additiveEvents.mouseup = 'mouseup'; - additiveEvents.touchstart = 'touchstart'; - additiveEvents.touchmove = 'touchmove'; - additiveEvents.touchend = 'touchend'; - additiveEvents.touchcancel = 'touchcancel'; - - additiveEvents.pointerdown = 'mousedown'; - additiveEvents.pointermove = 'mousemove'; - additiveEvents.pointerup = 'mouseup'; - additiveEvents.pointercancel = 'mouseup'; - } -}); - -Ext.define('EXTJS_23846.Gesture', { - override: 'Ext.event.publisher.Gesture', -}, function(Gesture) { - let gestures = Gesture.instance; - - if (Ext.supports.TouchEvents && !Ext.isWebKit && Ext.os.is.Desktop) { - gestures.handledDomEvents.push('mousedown', 'mousemove', 'mouseup'); - gestures.registerEvents(); - } -}); - Ext.define('EXTJS_18900.Pie', { override: 'Ext.chart.series.Pie', -- 2.20.1