From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <d.csapak@proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
key-exchange X25519 server-signature RSA-PSS (2048 bits))
(No client certificate requested)
by lists.proxmox.com (Postfix) with ESMTPS id D700F72A04
for <pve-devel@lists.proxmox.com>; Wed, 26 May 2021 10:59:11 +0200 (CEST)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
by firstgate.proxmox.com (Proxmox) with ESMTP id CDCB2E304
for <pve-devel@lists.proxmox.com>; Wed, 26 May 2021 10:58:41 +0200 (CEST)
Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com
[94.136.29.106])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
key-exchange X25519 server-signature RSA-PSS (2048 bits))
(No client certificate requested)
by firstgate.proxmox.com (Proxmox) with ESMTPS id 883C1E2B9
for <pve-devel@lists.proxmox.com>; Wed, 26 May 2021 10:58:40 +0200 (CEST)
Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1])
by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 5400246679
for <pve-devel@lists.proxmox.com>; Wed, 26 May 2021 10:58:40 +0200 (CEST)
From: Dominik Csapak <d.csapak@proxmox.com>
To: pve-devel@lists.proxmox.com
Date: Wed, 26 May 2021 10:58:30 +0200
Message-Id: <20210526085839.9808-3-d.csapak@proxmox.com>
X-Mailer: git-send-email 2.20.1
In-Reply-To: <20210526085839.9808-1-d.csapak@proxmox.com>
References: <20210526085839.9808-1-d.csapak@proxmox.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-SPAM-LEVEL: Spam detection results: 0
AWL 0.027 Adjusted score from AWL reputation of From: address
KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record
SPF_PASS -0.001 SPF: sender matches SPF record
Subject: [pve-devel] [PATCH widget-toolkit 02/11] Toolkit: set download url
for draw containers to '-'
X-BeenThere: pve-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>,
<mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>,
<mailto:pve-devel-request@lists.proxmox.com?subject=subscribe>
X-List-Received-Date: Wed, 26 May 2021 08:59:11 -0000
so that there can be no privacy leak, since the default points
to senchas server
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
src/Toolkit.js | 3 +++
src/panel/GaugeWidget.js | 2 ++
src/panel/RRDChart.js | 3 +++
3 files changed, 8 insertions(+)
diff --git a/src/Toolkit.js b/src/Toolkit.js
index ffbd47a..6787173 100644
--- a/src/Toolkit.js
+++ b/src/Toolkit.js
@@ -659,6 +659,9 @@ Ext.define('Proxmox.selection.CheckboxModel', {
},
});
+// override the download server url globally, for privacy reasons
+Ext.draw.Container.prototype.defaultDownloadServerUrl = "-";
+
// force alert boxes to be rendered with an Error Icon
// since Ext.Msg is an object and not a prototype, we need to override it
// after the framework has been initiated
diff --git a/src/panel/GaugeWidget.js b/src/panel/GaugeWidget.js
index 6cd6b60..0cc2079 100644
--- a/src/panel/GaugeWidget.js
+++ b/src/panel/GaugeWidget.js
@@ -20,6 +20,8 @@ Ext.define('Proxmox.panel.GaugeWidget', {
xtype: 'polar',
height: 120,
border: false,
+ // set to '-' to suppress warning in debug mode
+ downloadServerUrl: '-',
itemId: 'chart',
series: [{
type: 'gauge',
diff --git a/src/panel/RRDChart.js b/src/panel/RRDChart.js
index 41c839e..49b3ad2 100644
--- a/src/panel/RRDChart.js
+++ b/src/panel/RRDChart.js
@@ -61,6 +61,9 @@ Ext.define('Proxmox.widget.RRDChart', {
powerOfTwo: false,
+ // set to empty string to suppress warning in debug mode
+ downloadServerUrl: '-',
+
controller: {
xclass: 'Ext.app.ViewController',
--
2.20.1