From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id C12A8729AF for ; Wed, 26 May 2021 10:48:54 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id A9897DFC6 for ; Wed, 26 May 2021 10:48:24 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 31909DFBA for ; Wed, 26 May 2021 10:48:24 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 059004295B for ; Wed, 26 May 2021 10:48:18 +0200 (CEST) Date: Wed, 26 May 2021 10:48:16 +0200 From: Oguz Bektas To: Thomas Lamprecht Cc: Proxmox VE development discussion Message-ID: <20210526084816.GA14375@gaia.proxmox.com> Mail-Followup-To: Oguz Bektas , Thomas Lamprecht , Proxmox VE development discussion References: <20210525131559.1007131-1-o.bektas@proxmox.com> <00ebc5fa-145a-10ea-62e1-812d1ada7471@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <00ebc5fa-145a-10ea-62e1-812d1ada7471@proxmox.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-SPAM-LEVEL: Spam detection results: 1 AWL 1.195 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH container] setup: make randomize_crontab a state subroutine X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 26 May 2021 08:48:54 -0000 On Tue, May 25, 2021 at 03:26:12PM +0200, Thomas Lamprecht wrote: > On 25.05.21 15:15, Oguz Bektas wrote: > > for consistency in post_create_hook. still works as expected > > > > what's the reason/benefit again? it looked a bit ugly otherwise with all the other ones being state subs, so it's just a style change in the end. anything against this? > > > Signed-off-by: Oguz Bektas > > --- > > src/PVE/LXC/Setup/Base.pm | 6 +++--- > > 1 file changed, 3 insertions(+), 3 deletions(-) > > > > diff --git a/src/PVE/LXC/Setup/Base.pm b/src/PVE/LXC/Setup/Base.pm > > index d73335b..be41874 100644 > > --- a/src/PVE/LXC/Setup/Base.pm > > +++ b/src/PVE/LXC/Setup/Base.pm > > @@ -422,7 +422,7 @@ sub set_user_authorized_ssh_keys { > > $self->ct_modify_file("$home/.ssh/authorized_keys", $ssh_keys, perms => 0700); > > } > > > > -my $randomize_crontab = sub { > > +sub randomize_crontab { > > my ($self, $conf) = @_; > > > > my @files; > > @@ -450,7 +450,7 @@ my $randomize_crontab = sub { > > } > > $self->ct_file_set_contents($filename, $new); > > } > > -}; > > +} > > > > sub set_timezone { > > my ($self, $conf) = @_; > > @@ -493,7 +493,7 @@ sub post_create_hook { > > > > $self->template_fixup($conf); > > > > - &$randomize_crontab($self, $conf); > > + $self->randomize_crontab($conf); > > > > $self->set_user_password($conf, 'root', $root_password); > > $self->set_user_authorized_ssh_keys($conf, 'root', $ssh_keys) if $ssh_keys; > > >