From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 27AE67195E for ; Thu, 20 May 2021 16:59:18 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 25667267E5 for ; Thu, 20 May 2021 16:59:18 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 7E625267CD for ; Thu, 20 May 2021 16:59:17 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 55D9046638 for ; Thu, 20 May 2021 16:59:17 +0200 (CEST) From: Dominik Csapak To: pve-devel@lists.proxmox.com Date: Thu, 20 May 2021 16:59:16 +0200 Message-Id: <20210520145916.23222-4-d.csapak@proxmox.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20210520145916.23222-1-d.csapak@proxmox.com> References: <20210520145916.23222-1-d.csapak@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.015 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH manager 3/3] ui: ResourceGrid: correctly remove ResourceStore listener X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 20 May 2021 14:59:18 -0000 while the function in '.on' and '.un' are identical, they are not the *same* function, thus the '.un' does not really remove the listener, and we have leftover references to the grid which means it will never really garbage-collected instead, use '.mon' on the grid, which automatically cleans up the listeners Signed-off-by: Dominik Csapak --- www/manager6/grid/ResourceGrid.js | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/www/manager6/grid/ResourceGrid.js b/www/manager6/grid/ResourceGrid.js index c6757e9b..07048b88 100644 --- a/www/manager6/grid/ResourceGrid.js +++ b/www/manager6/grid/ResourceGrid.js @@ -125,14 +125,11 @@ Ext.define('PVE.grid.ResourceGrid', { var ws = me.up('pveStdWorkspace'); ws.selectById(record.data.id); }, - destroy: function() { - rstore.un("load", () => updateGrid()); - }, }, columns: rstore.defaultColumns(), }); me.callParent(); updateGrid(); - rstore.on("load", () => updateGrid()); + me.mon(rstore, 'load', () => updateGrid()); }, }); -- 2.20.1