From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 8E39D718F7 for ; Thu, 20 May 2021 12:04:32 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 84CBD2332A for ; Thu, 20 May 2021 12:04:02 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 0E48F2330B for ; Thu, 20 May 2021 12:04:01 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 91A0F46631 for ; Thu, 20 May 2021 12:03:54 +0200 (CEST) From: Lorenz Stechauner To: pve-devel@lists.proxmox.com Date: Thu, 20 May 2021 12:03:39 +0200 Message-Id: <20210520100341.31811-2-l.stechauner@proxmox.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20210520100341.31811-1-l.stechauner@proxmox.com> References: <20210520100341.31811-1-l.stechauner@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.371 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH v2 access-control 1/1] fix #3402: add Pool.Audit permission X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 20 May 2021 10:04:32 -0000 add new user "PVEPoolUser" and add Pool.Audit to "PVEAuditor". Signed-off-by: Lorenz Stechauner --- README | 1 + src/PVE/AccessControl.pm | 8 ++++++-- 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/README b/README index 33643a6..c706e5b 100644 --- a/README +++ b/README @@ -96,6 +96,7 @@ privileges: VM.Config.Options: modify any other VM configuration Pool.Allocate: create/remove/modify a pool. + Pool.Audit: view a pool Datastore.Allocate: create/remove/modify a data store. Datastore.AllocateSpace: allocate space on a datastore diff --git a/src/PVE/AccessControl.pm b/src/PVE/AccessControl.pm index f7d4e78..888875e 100644 --- a/src/PVE/AccessControl.pm +++ b/src/PVE/AccessControl.pm @@ -819,8 +819,12 @@ my $privgroups = { admin => [ 'Pool.Allocate', # create/delete pools ], - user => [], - audit => [], + user => [ + 'Pool.Audit', + ], + audit => [ + 'Pool.Audit', + ], }, }; -- 2.20.1