From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 8D6807171B for ; Wed, 19 May 2021 12:56:48 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 8B6AC19A80 for ; Wed, 19 May 2021 12:56:48 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 4E02A19A62 for ; Wed, 19 May 2021 12:56:47 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 2090C46608 for ; Wed, 19 May 2021 12:56:47 +0200 (CEST) From: =?UTF-8?q?Dominic=20J=C3=A4ger?= To: pve-devel@lists.proxmox.com Date: Wed, 19 May 2021 12:56:21 +0200 Message-Id: <20210519105622.6514-4-d.jaeger@proxmox.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20210519105622.6514-1-d.jaeger@proxmox.com> References: <20210519105622.6514-1-d.jaeger@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.668 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH manager 4/5] ui: panel/RunningChart: eslint fixes X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 19 May 2021 10:56:48 -0000 Signed-off-by: Dominic Jäger --- www/manager6/panel/RunningChart.js | 43 +++++++++++++++--------------- 1 file changed, 21 insertions(+), 22 deletions(-) diff --git a/www/manager6/panel/RunningChart.js b/www/manager6/panel/RunningChart.js index ab4c9039..19db8b50 100644 --- a/www/manager6/panel/RunningChart.js +++ b/www/manager6/panel/RunningChart.js @@ -63,14 +63,13 @@ Ext.define('PVE.widget.RunningChart', { tooltip: { trackMouse: true, renderer: function(tooltip, record, ctx) { - let me = this.getChart(); if (!record || !record.data) return; - let date = new Date(record.data.time); - let value = me.up().renderer(record.data.val); - tooltip.setHtml( - me.up().title + ': ' + value + '
' + - Ext.Date.format(date, 'H:i:s'), - ); + const view = this.getChart(); + const date = new Date(record.data.time); + const value = view.up().renderer(record.data.val); + const line1 = `${view.up().title}: ${value}`; + const line2 = Ext.Date.format(date, 'H:i:s'); + tooltip.setHtml(`${line1}
${line2}`); }, }, style: { @@ -100,12 +99,12 @@ Ext.define('PVE.widget.RunningChart', { timeFrame: 5*60, addDataPoint: function(value, time) { - let me = this.chart; - let panel = me.up(); + let view = this.chart; + let panel = view.up(); let now = new Date().getTime(); let begin = new Date(now - 1000 * panel.timeFrame).getTime(); - me.store.add({ + view.store.add({ time: time || now, val: value || 0, }); @@ -117,28 +116,28 @@ Ext.define('PVE.widget.RunningChart', { // records in the store do not take much space, but like this, // we prevent a memory leak when someone has the site open for a long time // with minimal graphical glitches - if (me.store.count() > panel.timeFrame * 20) { - var oldData = me.store.getData().createFiltered(function(item) { + if (view.store.count() > panel.timeFrame * 20) { + var oldData = view.store.getData().createFiltered(function(item) { return item.data.time < begin; }); - me.store.remove(oldData.getRange()); + view.store.remove(oldData.getRange()); } - me.timeaxis.setMinimum(begin); - me.timeaxis.setMaximum(now); - me.valuesprite.setText(panel.renderer(value || 0).toString()); - me.valuesprite.setAttributes({ - x: me.getWidth() - 15, - y: me.getHeight()/2, + view.timeaxis.setMinimum(begin); + view.timeaxis.setMaximum(now); + view.valuesprite.setText(panel.renderer(value || 0).toString()); + view.valuesprite.setAttributes({ + x: view.getWidth() - 15, + y: view.getHeight()/2, }, true); - me.redraw(); + view.redraw(); }, setTitle: function(title) { this.title = title; - var me = this.getComponent('title'); - me.update({ title: title }); + let titlebox = this.getComponent('title'); + titlebox.update({ title: title }); }, initComponent: function() { -- 2.20.1