From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 47171716A3 for ; Wed, 19 May 2021 12:56:49 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 2335919AAC for ; Wed, 19 May 2021 12:56:49 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 2AB7B19A4B for ; Wed, 19 May 2021 12:56:47 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id E496746614 for ; Wed, 19 May 2021 12:56:46 +0200 (CEST) From: =?UTF-8?q?Dominic=20J=C3=A4ger?= To: pve-devel@lists.proxmox.com Date: Wed, 19 May 2021 12:56:19 +0200 Message-Id: <20210519105622.6514-2-d.jaeger@proxmox.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20210519105622.6514-1-d.jaeger@proxmox.com> References: <20210519105622.6514-1-d.jaeger@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.646 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH manager 2/5] ui: panel/IPSet: eslint fixes X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 19 May 2021 10:56:49 -0000 Signed-off-by: Dominic Jäger --- www/manager6/panel/IPSet.js | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/www/manager6/panel/IPSet.js b/www/manager6/panel/IPSet.js index 303e518a..94117789 100644 --- a/www/manager6/panel/IPSet.js +++ b/www/manager6/panel/IPSet.js @@ -22,11 +22,11 @@ Ext.define('PVE.IPSetList', { initComponent: function() { var me = this; - if (me.ipset_panel == undefined) { + if (typeof me.ipset_panel === 'undefined') { throw "no rule panel specified"; } - if (me.base_url == undefined) { + if (typeof me.ipset_panel === 'undefined') { throw "no base_url specified"; } @@ -143,7 +143,7 @@ Ext.define('PVE.IPSetList', { ], listeners: { itemdblclick: run_editor, - select: function(sm, rec) { + select: function(_, rec) { var url = me.base_url + '/' + rec.data.name; me.ipset_panel.setBaseUrl(url); }, @@ -346,7 +346,7 @@ Ext.define('PVE.IPSetGrid', { metaData.tdCls = 'proxmox-invalid-row'; var html = '

' + Ext.htmlEncode(msg) + '

'; metaData.tdAttr = 'data-qwidth=600 data-qtitle="ERROR" data-qtip="' + - html.replace(/\"/g, '"') + '"'; + html.replace(/"/g, '"') + '"'; } } return value; -- 2.20.1