From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 8101071736 for ; Wed, 19 May 2021 12:57:18 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 7781F19A7F for ; Wed, 19 May 2021 12:56:48 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 2AFF519A4C for ; Wed, 19 May 2021 12:56:47 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id DEB9A46613 for ; Wed, 19 May 2021 12:56:46 +0200 (CEST) From: =?UTF-8?q?Dominic=20J=C3=A4ger?= To: pve-devel@lists.proxmox.com Date: Wed, 19 May 2021 12:56:18 +0200 Message-Id: <20210519105622.6514-1-d.jaeger@proxmox.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.691 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH manager 1/5] ui: panel/ConfigPanel: eslint fixes X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 19 May 2021 10:57:18 -0000 Signed-off-by: Dominic Jäger --- www/manager6/panel/ConfigPanel.js | 15 ++++++++------- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/www/manager6/panel/ConfigPanel.js b/www/manager6/panel/ConfigPanel.js index 23a6ee58..788615aa 100644 --- a/www/manager6/panel/ConfigPanel.js +++ b/www/manager6/panel/ConfigPanel.js @@ -68,11 +68,11 @@ Ext.define('PVE.panel.Config', { singleExpand: false, listeners: { selectionchange: function(treeList, selection) { - var me = this.up('panel'); - me.suspendLayout = true; - me.activateCard(selection.data.id); - me.suspendLayout = false; - me.updateLayout(); + let view = this.up('panel'); + view.suspendLayout = true; + view.activateCard(selection.data.id); + view.suspendLayout = false; + view.updateLayout(); }, itemclick: function(treelist, info) { var olditem = treelist.getSelection(); @@ -123,6 +123,7 @@ Ext.define('PVE.panel.Config', { menu.setSelection(selection); return cardid; } + return ''; }, activateCard: function(cardid) { @@ -160,7 +161,7 @@ Ext.define('PVE.panel.Config', { var activeTab; // leaving this undefined means items[0] will be the default tab if (stateid) { - var state = me.sp.get(stateid); + let state = me.sp.get(stateid); if (state && state.value) { // if this tab does not exist, it chooses the first activeTab = state.value; @@ -259,7 +260,7 @@ Ext.define('PVE.panel.Config', { var acard = me.getLayout().getActiveItem().itemId; // get the itemid of the new value var ncard = state.value || me.firstItem; - if (ncard && acard != ncard) { + if (ncard && acard !== ncard) { // select the chosen item menu.setSelection(root.findChild('id', ncard, true) || root.firstChild); } -- 2.20.1