From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <f.ebner@proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id BC0CD7B5F2 for <pve-devel@lists.proxmox.com>; Wed, 12 May 2021 14:33:03 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 86F9CD332 for <pve-devel@lists.proxmox.com>; Wed, 12 May 2021 14:33:03 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id EAF4ED2EB for <pve-devel@lists.proxmox.com>; Wed, 12 May 2021 14:33:01 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id B84B246565 for <pve-devel@lists.proxmox.com>; Wed, 12 May 2021 14:33:01 +0200 (CEST) From: Fabian Ebner <f.ebner@proxmox.com> To: pve-devel@lists.proxmox.com Date: Wed, 12 May 2021 14:32:49 +0200 Message-Id: <20210512123258.28178-1-f.ebner@proxmox.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.002 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH-SERIES] correctly handle warnings status X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/> List-Post: <mailto:pve-devel@lists.proxmox.com> List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe> X-List-Received-Date: Wed, 12 May 2021 12:33:03 -0000 There's a few places where we use the logic "OK" if and only if no error for a task status, but this is no longer true now that we also support ending in a warnings status (not yet used by anything, but the feature is there). Everything depends on the first patch and depedency bumps for pve-common are needed across the board. pve-common: Fabian Ebner (1): tools: add upid_status_is_error function src/PVE/Tools.pm | 8 ++++++++ 1 file changed, 8 insertions(+) pve-manager: Fabian Ebner (4): api/cli: tasks: don't treat warnings status as an error status nodes: startall: correctly handle warning status for delayed task cli: pveam: remove unused private sub cli tools: correctly handle warnings status PVE/API2/Nodes.pm | 2 +- PVE/API2/Tasks.pm | 5 ++++- PVE/CLI/pveam.pm | 6 ------ PVE/CLI/pveceph.pm | 2 +- PVE/CLI/pvenode.pm | 7 +++++-- PVE/CLI/vzdump.pm | 2 +- 6 files changed, 12 insertions(+), 12 deletions(-) pve-storage: Fabian Ebner (1): api: content: correctly handle warnings status for delayed task PVE/API2/Storage/Content.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) pve-container: Fabian Ebner (1): pct: correctly handle warnings task status src/PVE/CLI/pct.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) qemu-server: Fabian Ebner (2): cli tools: correctly handle warnings task status api: update vm: correctly handle warnings status for delayed task PVE/API2/Qemu.pm | 2 +- PVE/CLI/qm.pm | 2 +- PVE/CLI/qmrestore.pm | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) -- 2.20.1