From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 852317A31A for ; Fri, 7 May 2021 08:57:33 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 6F0E62734D for ; Fri, 7 May 2021 08:57:03 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id EFE1127344 for ; Fri, 7 May 2021 08:57:02 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id C37464651F for ; Fri, 7 May 2021 08:56:56 +0200 (CEST) From: Fabian Ebner To: pve-devel@lists.proxmox.com Date: Fri, 7 May 2021 08:56:52 +0200 Message-Id: <20210507065652.4896-1-f.ebner@proxmox.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20210506121632.8417-1-f.ebner@proxmox.com> References: <20210506121632.8417-1-f.ebner@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.003 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH v5 manager 7/7] ui: backup window: also reset removal fields when defaults API call fails X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 07 May 2021 06:57:33 -0000 to avoid showing settings for the wrong storage. Signed-off-by: Fabian Ebner --- Sorry for the delayed fix-up/follow-up to the series. Could also be squashed into patch #6. www/manager6/window/Backup.js | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/www/manager6/window/Backup.js b/www/manager6/window/Backup.js index 7048c366..77be6caf 100644 --- a/www/manager6/window/Backup.js +++ b/www/manager6/window/Backup.js @@ -141,6 +141,11 @@ Ext.define('PVE.window.Backup', { }, failure: function(response, opts) { initialDefaults = true; + + removeCheckbox.setHidden(true); + removeCheckbox.setValue(false); + pruneSettings.forEach(field => field.reset()); + Ext.Msg.alert(gettext('Error'), response.htmlStatus); }, }); -- 2.20.1