From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 4C17D7A043 for ; Thu, 6 May 2021 14:17:08 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 21FDB20259 for ; Thu, 6 May 2021 14:16:38 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 2BE5F201EC for ; Thu, 6 May 2021 14:16:36 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 0687B4651B for ; Thu, 6 May 2021 14:16:36 +0200 (CEST) From: Fabian Ebner To: pve-devel@lists.proxmox.com Date: Thu, 6 May 2021 14:16:29 +0200 Message-Id: <20210506121632.8417-4-f.ebner@proxmox.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20210506121632.8417-1-f.ebner@proxmox.com> References: <20210506121632.8417-1-f.ebner@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.003 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH v5 manager 3/6] ui: backup window: set loading mask early enough X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 06 May 2021 12:17:08 -0000 but not too early. Because of an ExtJS bug/limitation, it can only happen after the window is rendered, so use an afterrender listener. Without setting the mask there, the window will be active already before the storage selectors change listener triggers, which can only happen after the storage selectors store is loaded. Made noticable by the new "filling in defaults" behavior, but the issue was already present earlier, where the compression selector for PBS storages would be disabled late, after the window was already active. Also move the setValue call into the afterrender listener, so ordering is easy to verify/more stable. Reported-by: Thomas Lamprecht Signed-off-by: Fabian Ebner --- www/manager6/window/Backup.js | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/www/manager6/window/Backup.js b/www/manager6/window/Backup.js index 76a4987e..8d9824f3 100644 --- a/www/manager6/window/Backup.js +++ b/www/manager6/window/Backup.js @@ -46,6 +46,10 @@ Ext.define('PVE.window.Backup', { allowBlank: false, listeners: { change: function(f, v) { + if (!initialDefaults) { + me.setLoading(false); + } + if (v === null || v === undefined || v === '') { return; } @@ -87,7 +91,6 @@ Ext.define('PVE.window.Backup', { }, }, }); - storagesel.setValue(me.storage); me.formPanel = Ext.create('Ext.form.Panel', { bodyPadding: 10, @@ -172,6 +175,13 @@ Ext.define('PVE.window.Backup', { border: false, items: [me.formPanel], buttons: [helpBtn, '->', submitBtn], + listeners: { + afterrender: function() { + /// cleared within the storage selector's change listener + me.setLoading(gettext('Please wait...')); + storagesel.setValue(me.storage); + }, + }, }); me.callParent(); -- 2.20.1