From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 929257A040 for ; Thu, 6 May 2021 14:17:07 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 892CC20214 for ; Thu, 6 May 2021 14:16:37 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 07C6C201E0 for ; Thu, 6 May 2021 14:16:36 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id CB1A4464F9 for ; Thu, 6 May 2021 14:16:35 +0200 (CEST) From: Fabian Ebner To: pve-devel@lists.proxmox.com Date: Thu, 6 May 2021 14:16:28 +0200 Message-Id: <20210506121632.8417-3-f.ebner@proxmox.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20210506121632.8417-1-f.ebner@proxmox.com> References: <20210506121632.8417-1-f.ebner@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.150 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment POISEN_SPAM_PILL 0.1 Meta: its spam POISEN_SPAM_PILL_1 0.1 random spam to be learned in bayes POISEN_SPAM_PILL_3 0.1 random spam to be learned in bayes SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH v5 manager 2/6] ui: backup window: also set initialDefaults variable in failure case X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 06 May 2021 12:17:07 -0000 so that mailto and mode are not overwritten if the first /vzdump/defaults call failed, but a later one succeeds. Signed-off-by: Fabian Ebner --- www/manager6/window/Backup.js | 1 + 1 file changed, 1 insertion(+) diff --git a/www/manager6/window/Backup.js b/www/manager6/window/Backup.js index 72e8cb48..76a4987e 100644 --- a/www/manager6/window/Backup.js +++ b/www/manager6/window/Backup.js @@ -80,6 +80,7 @@ Ext.define('PVE.window.Backup', { initialDefaults = true; }, failure: function(response, opts) { + initialDefaults = true; Ext.Msg.alert(gettext('Error'), response.htmlStatus); }, }); -- 2.20.1