From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id E20987A021 for ; Thu, 6 May 2021 14:16:36 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id DCD83201FD for ; Thu, 6 May 2021 14:16:36 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id E7992201D7 for ; Thu, 6 May 2021 14:16:35 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id BDC7946520 for ; Thu, 6 May 2021 14:16:35 +0200 (CEST) From: Fabian Ebner To: pve-devel@lists.proxmox.com Date: Thu, 6 May 2021 14:16:27 +0200 Message-Id: <20210506121632.8417-2-f.ebner@proxmox.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20210506121632.8417-1-f.ebner@proxmox.com> References: <20210506121632.8417-1-f.ebner@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.000 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH v5 manager 1/6] ui: backup window: avoid issuing API call with null/empty parameter X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 06 May 2021 12:16:36 -0000 could be triggered when there are no backup storages at all configured or if the 'Backup now' button is clicked before the storage selector from the guests 'Backup' tab could load its store. Signed-off-by: Fabian Ebner --- www/manager6/window/Backup.js | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/www/manager6/window/Backup.js b/www/manager6/window/Backup.js index a6dc1798..72e8cb48 100644 --- a/www/manager6/window/Backup.js +++ b/www/manager6/window/Backup.js @@ -46,6 +46,10 @@ Ext.define('PVE.window.Backup', { allowBlank: false, listeners: { change: function(f, v) { + if (v === null || v === undefined || v === '') { + return; + } + let store = f.getStore(); let rec = store.findRecord('storage', v, 0, false, true, true); -- 2.20.1