From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 04E29796E1 for ; Tue, 4 May 2021 19:01:20 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id F0C25C1E1 for ; Tue, 4 May 2021 19:00:49 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 21FFEC1A2 for ; Tue, 4 May 2021 19:00:48 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id EC1B742A95 for ; Tue, 4 May 2021 19:00:47 +0200 (CEST) From: Stoiko Ivanov To: pve-devel@lists.proxmox.com Date: Tue, 4 May 2021 19:00:27 +0200 Message-Id: <20210504170032.8721-4-s.ivanov@proxmox.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20210504170032.8721-1-s.ivanov@proxmox.com> References: <20210504170032.8721-1-s.ivanov@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.011 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [pveproxy.pm, spiceproxy.pm] Subject: [pve-devel] [PATCH manager v2 1/1] proxy: fix wildcard address use X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 04 May 2021 17:01:20 -0000 This patch fixes a regression for hosts disabling ipv6 via kernel commandline ('ipv6.disable=1')introduced in commit fc087ec2b924dc9c72d3bf80face8a1731c15405 (disabling IPv6 via sysctl did not exhibit these problems) by hardcoding the address to '::', pveproxy and spiceproxy failed to start with: 'unable to create socket - Address family not supported by protocol' This patch depends on the commit in pve-common, which tries first binding to '::' and then falling back to '0.0.0.0', and needs a versioned dependency bump on libpve-common-perl. With this patch the listening addresses are (`ss -tlnp |grep 8006` output) * ipv6 disabled via kernel cmdline: '0.0.0.0:8006' * sysctl net.ipv6.conf.all.disable_ipv6=1: '*:8006' * sysctl net.ipv6.bindv6only=1: '[::]:8006' * else: '*:8006' Tested-by: Oguz Bektas Signed-off-by: Stoiko Ivanov --- PVE/Service/pveproxy.pm | 2 +- PVE/Service/spiceproxy.pm | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/PVE/Service/pveproxy.pm b/PVE/Service/pveproxy.pm index 4ecd442a..d10c4fe9 100755 --- a/PVE/Service/pveproxy.pm +++ b/PVE/Service/pveproxy.pm @@ -69,7 +69,7 @@ sub init { my $lockfh = IO::File->new(">>${accept_lock_fn}") || die "unable to open lock file '${accept_lock_fn}' - $!\n"; - my $listen_ip = $proxyconf->{LISTEN_IP} // "::0"; + my $listen_ip = $proxyconf->{LISTEN_IP}; my $socket = $self->create_reusable_socket(8006, $listen_ip); my $dirs = {}; diff --git a/PVE/Service/spiceproxy.pm b/PVE/Service/spiceproxy.pm index 24be0ed7..50b81c18 100755 --- a/PVE/Service/spiceproxy.pm +++ b/PVE/Service/spiceproxy.pm @@ -39,7 +39,7 @@ sub init { my $lockfh = IO::File->new(">>${accept_lock_fn}") || die "unable to open lock file '${accept_lock_fn}' - $!\n"; - my $listen_ip = $proxyconf->{LISTEN_IP} // "::0"; + my $listen_ip = $proxyconf->{LISTEN_IP}; my $socket = $self->create_reusable_socket(3128, $listen_ip); $self->{server_config} = { -- 2.20.1