From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id D9952794A8 for ; Tue, 4 May 2021 12:12:35 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 51191273B2 for ; Tue, 4 May 2021 12:12:35 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 0D7DE27342 for ; Tue, 4 May 2021 12:12:33 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id DCB1242A5B for ; Tue, 4 May 2021 12:12:32 +0200 (CEST) From: Stoiko Ivanov To: pve-devel@lists.proxmox.com Date: Tue, 4 May 2021 12:12:15 +0200 Message-Id: <20210504101222.21276-2-s.ivanov@proxmox.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20210504101222.21276-1-s.ivanov@proxmox.com> References: <20210504101222.21276-1-s.ivanov@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.012 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [perl.org, daemon.pm] Subject: [pve-devel] [PATCH common 1/2] daemon: drop Domain parameter from create_reusable_socket X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 04 May 2021 10:12:35 -0000 The Domain parameter for IO::Socket::IP is not used/needed. It is needed to create a IP Socket when calling IO::Socket->new, but here we call IO::Socket::IP-new directly (see [0]). [0] https://perldoc.perl.org/IO::Socket::IP Signed-off-by: Stoiko Ivanov --- src/PVE/Daemon.pm | 1 - 1 file changed, 1 deletion(-) diff --git a/src/PVE/Daemon.pm b/src/PVE/Daemon.pm index 905635a..79b90ad 100644 --- a/src/PVE/Daemon.pm +++ b/src/PVE/Daemon.pm @@ -820,7 +820,6 @@ sub create_reusable_socket { } else { $socket = IO::Socket::IP->new( - Domain => PF_INET6, LocalHost => $host, LocalPort => $port, Listen => SOMAXCONN, -- 2.20.1