From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 65E2A7938F for ; Tue, 4 May 2021 10:10:44 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 5AF8C24977 for ; Tue, 4 May 2021 10:10:14 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id C413124926 for ; Tue, 4 May 2021 10:10:12 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 9C7DC41B8B for ; Tue, 4 May 2021 10:10:12 +0200 (CEST) From: Fabian Ebner To: pve-devel@lists.proxmox.com Date: Tue, 4 May 2021 10:09:57 +0200 Message-Id: <20210504081004.21898-4-f.ebner@proxmox.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20210504081004.21898-1-f.ebner@proxmox.com> References: <20210504081004.21898-1-f.ebner@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.000 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH zsync 03/10] usage: describe flag parameters correctly X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 04 May 2021 08:10:44 -0000 It's not possible to provide a false value. From the documentation for GetOptionsFromArray: The argument specification is optional. If omitted, the option is considered boolean, a value of 1 will be assigned when the option is used on the command line. Make it clear that specifying the flag alone already enables it. Signed-off-by: Fabian Ebner --- pve-zsync | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/pve-zsync b/pve-zsync index deecfed..2c10a4d 100755 --- a/pve-zsync +++ b/pve-zsync @@ -1114,9 +1114,9 @@ $PROGNAME create -dest -source [OPTIONS] name of the sync job, if not set it is default - -skip boolean + -skip - if this flag is set it will skip the first sync + If specified, skip the first sync. -source string @@ -1126,9 +1126,9 @@ $PROGNAME create -dest -source [OPTIONS] name of the user on the source target, root by default - -properties boolean + -properties - Include the dataset's properties in the stream. + If specified, include the dataset's properties in the stream. -dest-config-path string @@ -1168,13 +1168,13 @@ $PROGNAME sync -dest -source [OPTIONS]\n name of the user on the source target, root by default - -verbose boolean + -verbose - print out the sync progress. + If specified, print out the sync progress. - -properties boolean + -properties - Include the dataset's properties in the stream. + If specified, include the dataset's properties in the stream. -dest-config-path string @@ -1199,7 +1199,7 @@ $PROGNAME help [OPTIONS] Command name - -verbose boolean + -verbose Verbose output format. }, -- 2.20.1