From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 28F6A78630 for ; Fri, 30 Apr 2021 09:19:58 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 179DB24F1D for ; Fri, 30 Apr 2021 09:19:28 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 75BEF24F10 for ; Fri, 30 Apr 2021 09:19:27 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 30DBA427DF for ; Fri, 30 Apr 2021 09:12:10 +0200 (CEST) Date: Fri, 30 Apr 2021 09:12:09 +0200 From: Wolfgang Bumiller To: Stoiko Ivanov Cc: pve-devel@lists.proxmox.com Message-ID: <20210430071209.7xq6aobehmvfhngc@wobu-vie.proxmox.com> References: <20210429133702.23584-1-s.ivanov@proxmox.com> <20210429133702.23584-3-s.ivanov@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210429133702.23584-3-s.ivanov@proxmox.com> User-Agent: NeoMutt/20180716 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.022 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [pveproxy.pm, spiceproxy.pm] Subject: Re: [pve-devel] [RFC manager 1/1] proxy: fix wildcard address use X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 30 Apr 2021 07:19:58 -0000 On Thu, Apr 29, 2021 at 03:37:02PM +0200, Stoiko Ivanov wrote: > This patch fixes a regression for hosts disabling ipv6 via kernel > commandline ('ipv6.disable=1')introduced in commit > fc087ec2b924dc9c72d3bf80face8a1731c15405 > > by hardcoding the address to '::', pveproxy and spiceproxy failed to > start with: > 'unable to create socket - Address family not supported by protocol' > > Disabling IPv6 via sysctl did not exhibit these problems. > > This patch depends on the commit in pve-common and needs a versioned > dependency bump on libpve-common-perl. > > With this patch the listening addresses are (`ss -tlnp |grep 8006` output) > * disabled via kernel cmdline: '0.0.0.0:8006' > * disabled via sysctl net.ipv6.conf.all.disable_ipv6=1: '0.0.0.0:8006' > * else: '*:8006' > > Signed-off-by: Stoiko Ivanov > --- > PVE/Service/pveproxy.pm | 2 +- > PVE/Service/spiceproxy.pm | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/PVE/Service/pveproxy.pm b/PVE/Service/pveproxy.pm > index 4ecd442a..742c0a9a 100755 > --- a/PVE/Service/pveproxy.pm > +++ b/PVE/Service/pveproxy.pm > @@ -69,7 +69,7 @@ sub init { > my $lockfh = IO::File->new(">>${accept_lock_fn}") || > die "unable to open lock file '${accept_lock_fn}' - $!\n"; > > - my $listen_ip = $proxyconf->{LISTEN_IP} // "::0"; > + my $listen_ip = $proxyconf->{LISTEN_IP} // PVE::Tools::get_wildcard_address(); > my $socket = $self->create_reusable_socket(8006, $listen_ip); ^ This passes `Domain => PF_INET6`. That makes no sense given that I can literally give it an IPv4 :S It also actually uses getaddrinfo in the background, however, the commmit forcing this to be 0 explains: perl's IO::Socket::IP passes AI_ADDRCONFIG if no GetAddrInfoFlags are passed, which is often useful but also causes it to error when explicitly trying to bind to 127.0.0.1 when there are no _other_ IPv4 addresses present. In this case however, we don't do that, so maybe instead of ending up using `getaddrinfo` twice, we should just make this an optional parameter? I'm hoping passing `undef` as host, the proper port and `AI_ADDRCONFIG | AI_PASSIVE` here should do the same? We also don't use `$listen_ip` for anything else either, so we don't need it explicitly ;-) > > my $dirs = {}; > diff --git a/PVE/Service/spiceproxy.pm b/PVE/Service/spiceproxy.pm > index 24be0ed7..34882ca4 100755 > --- a/PVE/Service/spiceproxy.pm > +++ b/PVE/Service/spiceproxy.pm > @@ -39,7 +39,7 @@ sub init { > my $lockfh = IO::File->new(">>${accept_lock_fn}") || > die "unable to open lock file '${accept_lock_fn}' - $!\n"; > > - my $listen_ip = $proxyconf->{LISTEN_IP} // "::0"; > + my $listen_ip = $proxyconf->{LISTEN_IP} // PVE::Tools::get_wildcard_address(); > my $socket = $self->create_reusable_socket(3128, $listen_ip); > > $self->{server_config} = { > -- > 2.20.1