From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 2A78A778D4 for ; Wed, 28 Apr 2021 13:54:54 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 16363DB0A for ; Wed, 28 Apr 2021 13:54:24 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 72CB3DAFF for ; Wed, 28 Apr 2021 13:54:23 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 303C346271 for ; Wed, 28 Apr 2021 13:45:41 +0200 (CEST) Date: Wed, 28 Apr 2021 13:42:21 +0200 From: Oguz Bektas To: Thomas Lamprecht Cc: Proxmox VE development discussion Message-ID: <20210428114221.GA11014@gaia.proxmox.com> Mail-Followup-To: Oguz Bektas , Thomas Lamprecht , Proxmox VE development discussion References: <20210428111608.694745-1-o.bektas@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-SPAM-LEVEL: Spam detection results: 1 AWL 1.426 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH docs] pveproxy: improve LISTEN_IP doc X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 28 Apr 2021 11:54:54 -0000 hi, thanks for checking. On Wed, Apr 28, 2021 at 01:35:40PM +0200, Thomas Lamprecht wrote: > On 28.04.21 13:16, Oguz Bektas wrote: > > * fix small typo > > * add details for link-local addresses > > * mention that pveproxy needs to be restarted > > > > Signed-off-by: Oguz Bektas > > --- > > pveproxy.adoc | 10 +++++++++- > > 1 file changed, 9 insertions(+), 1 deletion(-) > > > > diff --git a/pveproxy.adoc b/pveproxy.adoc > > index 08c5f63..b9f8ade 100644 > > --- a/pveproxy.adoc > > +++ b/pveproxy.adoc > > @@ -71,10 +71,18 @@ exposure to the public internet: > > > > LISTEN_IP="192.0.2.1" > > > > -Similarly you can also set a n IPv6 address: > > +Similarly you can also set an IPv6 address: > > > > LISTEN_IP="2001:db8:85a3::1" > > > > +And for a link-local IPv6 address on vmbr0 (interface name is necessary in this case): > > Does not reads like an actual sentence... I'd write something a long the lines of: > > "Note, if you want to specify a link-local IPv6 address, you need to provide the interface name itself:" okay > > > + > > + LISTEN_IP="fe80::d8ee:34ff:fe37:4579%vmbr0" > > + > > +After the change you have to restart `pveproxy` for it to take effect: > > I'd specifically state that a reload is not enough and then add a small warning that > a restart can stop some existing workers (not all, but e.g., shell connection is stopped > and reconnected which may loose info on CTs without a screen/tmux instance running). > Also, there's a short time window where no new connections are accepted IIRC (albeit > I was the one fixing that for reload it's been to long since then, so not sure anymore) i think the phrasing "you have to restart" already emphasizes this, adding too many warnings or notes would just confuse users in my opinion. though i don't see any harm in making the **restart** bold in that sentence and adding that small warning about possible connection drop. > > > + > > + systemctl restart pveproxy > > and spiceproxy? ah yes forgot that, also adding to v2 > > > + > > WARNING: The nodes in a cluster need access to `pveproxy` for communication, > > possibly on different sub-nets. It is **not recommended** to set `LISTEN_IP` on > > clustered systems. > >