From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 755E477398; Tue, 27 Apr 2021 10:48:53 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 601371D899; Tue, 27 Apr 2021 10:48:23 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id DDF1A1D890; Tue, 27 Apr 2021 10:48:22 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id A4EA441E17; Tue, 27 Apr 2021 10:48:22 +0200 (CEST) From: Stefan Reiter To: pbs-devel@lists.proxmox.com, pve-devel@lists.proxmox.com Date: Tue, 27 Apr 2021 10:48:16 +0200 Message-Id: <20210427084816.3364-1-s.reiter@proxmox.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.019 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH proxmox-backup] file-restore: fix package name for kernel/initramfs image X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 27 Apr 2021 08:48:53 -0000 Signed-off-by: Stefan Reiter --- Note that 'proxmox-backup-restore-image' is listed as 'recommended', not 'depends', which somewhat makes sense, as CT restore works without it as well, but maybe we should include it in the PVE installation ISO somehow? Or just make it a depends? atm after installing a fresh PVE, the 'File Restore' button for VMs only shows this message until a user manually installs this package. src/bin/proxmox_file_restore/qemu_helper.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/bin/proxmox_file_restore/qemu_helper.rs b/src/bin/proxmox_file_restore/qemu_helper.rs index 0f3a7feb..bb16bf14 100644 --- a/src/bin/proxmox_file_restore/qemu_helper.rs +++ b/src/bin/proxmox_file_restore/qemu_helper.rs @@ -51,7 +51,7 @@ fn validate_img_existance() -> Result<(), Error> { let kernel = PathBuf::from(buildcfg::PROXMOX_BACKUP_KERNEL_FN); let initramfs = PathBuf::from(buildcfg::PROXMOX_BACKUP_INITRAMFS_FN); if !kernel.exists() || !initramfs.exists() { - bail!("cannot run file-restore VM: package 'proxmox-file-restore' is not (correctly) installed"); + bail!("cannot run file-restore VM: package 'proxmox-backup-restore-image' is not (correctly) installed"); } Ok(()) } -- 2.20.1