From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id E8AFF76712 for ; Fri, 23 Apr 2021 12:15:16 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id DD70D27693 for ; Fri, 23 Apr 2021 12:15:16 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 5BA3D27641 for ; Fri, 23 Apr 2021 12:15:15 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 4422946432 for ; Fri, 23 Apr 2021 12:15:05 +0200 (CEST) From: Fabian Ebner To: pve-devel@lists.proxmox.com Date: Fri, 23 Apr 2021 12:14:51 +0200 Message-Id: <20210423101501.27300-2-f.ebner@proxmox.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20210423101501.27300-1-f.ebner@proxmox.com> References: <20210423101501.27300-1-f.ebner@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH storage 01/11] diskmanage: add wipe_blockdev method X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 23 Apr 2021 10:15:17 -0000 based on the wipe_disks method from pve-manager's Ceph/Tools.pm with the following main differences: * use wipefs to wipe labels first (to avoid sgdisk complaining about the backed up GPT structure on a subsequent GPT initialization) * only take one device as an argument * do not use an absolute path for 'dd' * die if one of the command fails The wipefs command makes checks and complains about e.g. mounted or active devices. One could supply --force to wipefs, but in many such situations it does not work as expected, because the device would still be detected as in-use afterwards, and further manaual steps would be needed. Signed-off-by: Fabian Ebner --- PVE/Diskmanage.pm | 27 +++++++++++++++++++++++++++ 1 file changed, 27 insertions(+) diff --git a/PVE/Diskmanage.pm b/PVE/Diskmanage.pm index b916d2e..612d976 100644 --- a/PVE/Diskmanage.pm +++ b/PVE/Diskmanage.pm @@ -7,6 +7,7 @@ use PVE::ProcFSTools; use Data::Dumper; use Cwd qw(abs_path); use Fcntl ':mode'; +use File::Basename; use File::stat; use JSON; @@ -841,4 +842,30 @@ sub append_partition { return $partition; } +# Wipes all labels and the first 200 MiB of a disk/partition (or the whole if it is smaller). +# Expected to be called with a result of verify_blockdev_path(). +sub wipe_blockdev { + my ($devpath) = @_; + + my $wipefs_cmd = ['wipefs', '--all', $devpath]; + + my $dd_cmd = ['dd', 'if=/dev/zero', "of=${devpath}", 'bs=1M', 'conv=fdatasync']; + + my $devname = basename($devpath); + my $dev_size = PVE::Tools::file_get_contents("/sys/class/block/$devname/size"); + + ($dev_size) = $dev_size =~ m|(\d+)|; # untaint $dev_size + die "Couldn't get the size of the device $devname\n" if !defined($dev_size); + + my $size = ($dev_size * 512 / 1024 / 1024); + my $count = ($size < 200) ? $size : 200; + + push @{$dd_cmd}, "count=${count}"; + + print "wiping disk/partition: ${devpath}\n"; + + run_command($wipefs_cmd, errmsg => "error wiping labels for '${devpath}'"); + run_command($dd_cmd, errmsg => "error wiping '${devpath}'"); +} + 1; -- 2.20.1