From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 9753C75AEF for ; Thu, 22 Apr 2021 14:30:43 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 8E3481BF00 for ; Thu, 22 Apr 2021 14:30:13 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id C95241BEF5 for ; Thu, 22 Apr 2021 14:30:11 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 91B084626B for ; Thu, 22 Apr 2021 14:30:11 +0200 (CEST) From: Aaron Lauterer To: pve-devel@lists.proxmox.com Date: Thu, 22 Apr 2021 14:30:10 +0200 Message-Id: <20210422123010.14006-2-a.lauterer@proxmox.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20210422123010.14006-1-a.lauterer@proxmox.com> References: <20210422123010.14006-1-a.lauterer@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.000 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [netfilter.org] Subject: [pve-devel] [PATCH manager] ui: firewall: rule: maxlength for source and dest X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 22 Apr 2021 12:30:43 -0000 Limiting the length of the source and dest paramters helps to avoid problems with iptables-restore which would not apply a rule if a parameter is larger than the parameter buffer (1024)[0]. As the API is already limiting this, we should also reflect that in the GUI and give people a hint that IP sets are most likely the better approach. [0] http://git.netfilter.org/iptables/tree/iptables/xshared.c?h=v1.8.7#n469 Signed-off-by: Aaron Lauterer --- This one "needs" the firewall patch 'fix #967: source: dest: limit length' As always when it comes to messages, someone might have a better idea how to phrase the maxLengthText. www/manager6/grid/FirewallRules.js | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/www/manager6/grid/FirewallRules.js b/www/manager6/grid/FirewallRules.js index 424bdfcb..f32a1ea1 100644 --- a/www/manager6/grid/FirewallRules.js +++ b/www/manager6/grid/FirewallRules.js @@ -135,7 +135,8 @@ Ext.define('PVE.FirewallRulePanel', { base_url: me.list_refs_url, value: '', fieldLabel: gettext('Source'), - + maxLength: 512, + maxLengthText: gettext('Too long, consider using IP sets.'), }, { xtype: 'pveIPRefSelector', @@ -145,6 +146,8 @@ Ext.define('PVE.FirewallRulePanel', { base_url: me.list_refs_url, value: '', fieldLabel: gettext('Destination'), + maxLength: 512, + maxLengthText: gettext('Too long, consider using IP sets.'), }, ); -- 2.20.1