From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 9480F74FC2 for ; Tue, 20 Apr 2021 20:34:25 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 8552027512 for ; Tue, 20 Apr 2021 20:33:55 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id AF088274F8 for ; Tue, 20 Apr 2021 20:33:53 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 2ED7E45F03 for ; Tue, 20 Apr 2021 20:25:44 +0200 (CEST) From: Stoiko Ivanov To: pve-devel@lists.proxmox.com Date: Tue, 20 Apr 2021 20:25:38 +0200 Message-Id: <20210420182540.25204-1-s.ivanov@proxmox.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [RFC pve-kernel-meta 0/2] boot ZFS on legacy BIOS systems from vfat X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 20 Apr 2021 18:34:25 -0000 This patchset has been long overdue, and complements the solution to booting ZFS on UEFI systems using systemd-boot. With the upgrade of ZFS 2.0.0 (and it's support for ZSTD compression), quite a few users found out that their systems were still booted with legacy bios boot and were consequently rendered unbootable with enabling zstd compression on (a dataset on rpool). The solution is inspired by our community-forum, especially @avw, and seems rather lightweight (patch 2/2 is best viewed with '-w'). My first approach was to generate a working grub-config ourselves, but given that grub has a few years of handling special cases - bind-mounting the ESP on /boot and running 'update-grub' seems like a less painful way. * patch 1/2 renames pve-efiboot-tool to proxmox-boot-tool (which seems more appropriate by now) * patch 2/2 adds support for installing grub appropriately on the ESPs and running the kernel sync-logic in a way that update-grub feels fine with Sending as RFC, because this is a proof-of-concept and missing quite a few things. What works: * installing this version on a root ZFS RAID-Z@ PVE (based on an old pre 6.2 install) * reformatting all 4 ESPs `proxmox-boot-tool format /dev/sda2 --force) * initializing them * rebooting into 5.4.106 and zfs 2.0.0 * upgrading the pool, setting compression=zstd, writing a file, rebooting (successfully) * rebooting into an old 5.3 kernel - and getting greeted by busy-box instead of grub-rescue What's missing (at least): * support in the installer * the renaming is not quite through (the kernel-hooks are still containing pve/efi in their name) * testing the removal part of the kernel-sync Stoiko Ivanov (2): proxmox-boot-tool: rename from pve-efiboot-tool proxmox-boot-tool: handle legacy boot zfs installs Makefile | 2 +- bin/Makefile | 2 +- bin/{pve-efiboot-tool => proxmox-boot-tool} | 21 ++++-- debian/pve-kernel-helper.install | 2 +- debian/pve-kernel-helper.links | 1 + {efiboot => proxmox-boot}/Makefile | 0 {efiboot => proxmox-boot}/functions | 0 {efiboot => proxmox-boot}/pve-auto-removal | 0 {efiboot => proxmox-boot}/pve-efiboot-sync | 2 +- {efiboot => proxmox-boot}/zz-pve-efiboot | 81 +++++++++++++++------ 10 files changed, 75 insertions(+), 36 deletions(-) rename bin/{pve-efiboot-tool => proxmox-boot-tool} (94%) create mode 100644 debian/pve-kernel-helper.links rename {efiboot => proxmox-boot}/Makefile (100%) rename {efiboot => proxmox-boot}/functions (100%) rename {efiboot => proxmox-boot}/pve-auto-removal (100%) rename {efiboot => proxmox-boot}/pve-efiboot-sync (84%) rename {efiboot => proxmox-boot}/zz-pve-efiboot (69%) -- 2.20.1